Bug 209325 - graphics/qt5-3d add libassimp
Summary: graphics/qt5-3d add libassimp
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-06 10:08 UTC by groot
Modified: 2016-05-29 09:12 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (kde)


Attachments
Adds libassimp (1.98 KB, patch)
2016-05-06 10:08 UTC, groot
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description groot 2016-05-06 10:08:02 UTC
Created attachment 170042 [details]
Adds libassimp

This is work from area51, the KDE-FreeBSD staging area, by Ralf Nolden.

Adds libassimp dependency to qt5-3d, for general 3d-model-loading. Patch applies with -p4
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-28 16:50:19 UTC
It fails to build on 9.3a, as libassimp is built, but not detected by qmake ?

http://people.freebsd.org/~pi/logs/graphics__qt5-3d-93a-1464448470.txt

The other builds are fine.
Comment 2 Marie Loise Nolden 2016-05-28 20:58:44 UTC
I can only reproduce the error though I wonder why your build log uses clang instead of gcc on 9.3. Anyway, that won't work. 

Please let this port out of your commits, we will prepare a working version with 5.6 and it's a technical preview in 5.5.1 anyway, so there's no requirement to have it in ports as no other port is using it. I also wonder why it stopped working after we tested this some month ago :/
Comment 3 Marie Loise Nolden 2016-05-28 20:59:34 UTC
please note that bsd.qt.mk should not contain "3d" in it, otherwise the devel/qt5 metaport gets broken.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-29 03:25:26 UTC
(In reply to nolden from comment #3)

It has 3d in it:

QT_DIST=                3d base canvas3d connectivity declarative doc enginio graphicaleffects imageformats \

so where does this come from ?
Comment 5 Marie Loise Nolden 2016-05-29 09:12:00 UTC
sorry for the last post - everything is correct, I checked building devel/qt5. qt5-3d is working as expected.

The problem was that the assimp port dependency got added in our 5.6 branch and got erroneously imported back into 5.5 and trunk. That is now reverted in our branches so no updates required for qt5-3d for Qt 5.5.1.

Please close the PR. Thank you for checking though.