Bug 209493 - [MAINTAINER] audio/pd - Fix inbuilt documentation
Summary: [MAINTAINER] audio/pd - Fix inbuilt documentation
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
Depends on:
Reported: 2016-05-14 03:59 UTC by Tobias Brodel
Modified: 2016-05-14 15:08 UTC (History)
2 users (show)

See Also:

svn diff for audio/pd (3.73 KB, patch)
2016-05-14 03:59 UTC, Tobias Brodel
no flags Details | Diff
poudriere log for audio/pd (231.55 KB, text/plain)
2016-05-14 04:01 UTC, Tobias Brodel
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Brodel 2016-05-14 03:59:54 UTC
Created attachment 170267 [details]
svn diff for audio/pd

Currently the inbuilt documentation in Pd cannot be accessed: the help browser cannot find its references and inbuilt objects cannot find their help-patches.

This diff removes files/patch-src_s__main.c which intends to point pd towards to ${LOCALBASE}/share/doc/pd instead of ${LOCALBASE}/lib/pd/doc. Unfortunately the patch actually ends up telling Pd to look in ${LOCALBASE}/lib/pd/share/doc/pd, a nonexistent directory. 

The do-install target already symlinks ${LOCALBASE}/share/doc/pd to ${LOCALBASE}/lib/pd/doc which is all Pd needs to find its docs. The patch I'm proposing to remove actually breaks this functionality.


Also included in the diff are some changes to satisfy portlint: I've removed an explicit reference to /usr/bin/tclsh and regenerated files/patch-extra_pd_pd.c with `make makepatch` which renamed it as `files/patch-extra_pd~_pd~.c.

Finally I've modified the post-patch target to reflect patches I got merged upstream: all references to alloca.h are now #ifdeffed to only apply to OS X and Linux within the Pd base. Only third-party libraries (files under ${WRKSRC}/extra) still contain non-portable includes.
Comment 1 Tobias Brodel 2016-05-14 04:01:20 UTC
Created attachment 170268 [details]
poudriere log for audio/pd
Comment 2 Kurt Jaeger freebsd_committer 2016-05-14 15:08:18 UTC
Committed, thanks!
Comment 3 commit-hook freebsd_committer 2016-05-14 15:08:44 UTC
A commit references this bug:

Author: pi
Date: Sat May 14 15:08:08 UTC 2016
New revision: 415189
URL: https://svnweb.freebsd.org/changeset/ports/415189

  audio/pd: Fix builtin documentation

  - also pet portlint

  PR:		209493
  Submitted by:	Tobias Brodel <brittlehaus@gmail.com> (maintainer)