Bug 209541 - java/intellij: Update to 2016.1.2
Summary: java/intellij: Update to 2016.1.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Boris Samorodov
Depends on:
Reported: 2016-05-16 08:33 UTC by Boris Samorodov
Modified: 2016-05-16 20:17 UTC (History)
1 user (show)

See Also:
tobik: maintainer-feedback+

Update java/intellij to 2016.1.2 (46.86 KB, patch)
2016-05-16 08:33 UTC, Boris Samorodov
no flags Details | Diff
Update to a new version, remove bundled linux-only JRE (40.86 KB, patch)
2016-05-16 14:41 UTC, Boris Samorodov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Boris Samorodov freebsd_committer 2016-05-16 08:33:56 UTC
Created attachment 170344 [details]
Update java/intellij to 2016.1.2

A new version is available.
Comment 1 Tobias Kortkamp freebsd_committer 2016-05-16 12:02:06 UTC
Thanks, looks mostly good to me. I see two problems atm:
- You're installing the bundled Linux-only JRE.  Please remove it.
- You're installing pty4j-0.6.jar. Currently the java/intellij-pty4j port installs both a native component of pty4j and a jar that includes FreeBSD patches.  I'm assuming that pty4j 0.6 now includes those.  There does not seem to be a 0.6 release at https://github.com/traff/pty4j so it's hard to tell what the differences between 0.5 and 0.6 really are.  IMHO the best thing to do now is to change java/intellij-pty4j to not install pty4j-0.5.jar.

You're also free to take over maintainership if you want to, since I'm using https://github.com/idea4bsd/idea4bsd now.
Comment 2 Boris Samorodov freebsd_committer 2016-05-16 14:41:08 UTC
Created attachment 170362 [details]
Update to a new version, remove bundled linux-only JRE

Tobias, thank you for you help and comments.
Here is a resived patch.
I've submitted a new PR about pty4j part (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209552)
Comment 3 Tobias Kortkamp freebsd_committer 2016-05-16 16:30:22 UTC
Thanks. Looks good to me :)
Comment 4 commit-hook freebsd_committer 2016-05-16 19:10:41 UTC
A commit references this bug:

Author: bsam
Date: Mon May 16 19:10:11 UTC 2016
New revision: 415358
URL: https://svnweb.freebsd.org/changeset/ports/415358

  java/intellij: update to version 2016.1.2, take maintainership.

  PR:		209541
  Submitted by:	bsam (me)
  Approved by:	Tobias Kortkamp <t@tobik.me>

Comment 5 Boris Samorodov freebsd_committer 2016-05-16 20:17:09 UTC
Committed, thanks!