Bug 209754 - [PATCH] fix port vulnerability check fail since r415842 (due to dp_PKGNAME not declared)
Summary: [PATCH] fix port vulnerability check fail since r415842 (due to dp_PKGNAME no...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-05-25 18:11 UTC by Thibault Payet
Modified: 2016-06-04 09:35 UTC (History)
4 users (show)

See Also:

Attachments
the svn diff (819 bytes, patch)
2016-05-25 18:11 UTC, Thibault Payet 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Payet 2016-05-25 18:11:32 UTC 
Created attachment 170663 [details]
the svn diff

Since r415842 it is impossible to build port due to the fact that dp_PKGNAME is not declared , and so the scripts check-vulnerable.sh fails.
Here is a patch that fix it
Comment 1 borius 2016-05-25 18:29:45 UTC 
confirm that
Comment 2 Oleg Streejak 2016-05-25 18:44:29 UTC 
confirm that this patch works as expected
Comment 3 Baptiste Daroussin freebsd_committer freebsd_triage 2016-05-25 18:47:48 UTC 
Fixed in the meantime, sorry I haven't seen your patch first
Comment 4 Nick Evans 2016-06-03 22:32:12 UTC 
Looks like a variation of this has cropped up:

/usr/ports/net-mgmt/bsnmp-ucd # make
/usr/ports/Mk/Scripts/check-vulnerable.sh: vlist: parameter not set
*** [check-vulnerable] Error code 2

Stop in /usr/ports/net-mgmt/bsnmp-ucd.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-06-04 09:35:27 UTC 
A commit references this bug:

Author: mat
Date: Sat Jun  4 09:35:21 UTC 2016
New revision: 416352
URL: https://svnweb.freebsd.org/changeset/ports/416352

Log:
  Fix logic a bit, in case pkg is not installed (I guess.)

  PR:		209754
  Reported by:	Nick Evans
  Sponsored by:	Absolight

Changes:
  head/Mk/Scripts/check-vulnerable.sh