Bug 209756 - Some ports listed in the INDEX file are without (required) version
Summary: Some ports listed in the INDEX file are without (required) version
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Rene Ladan
URL: https://svnweb.freebsd.org/ports?view...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-25 23:30 UTC by Vladimir Omelchuk
Modified: 2016-05-26 16:28 UTC (History)
4 users (show)

See Also:


Attachments
fix up fallout from r415864 where 14 ports came up with empty PORTVERSION (6.00 KB, patch)
2016-05-26 16:19 UTC, Matthias Andree
no flags Details | Diff
DO NOT APPLY -- diffs in comparison to ports HEAD as of r415863 (7.41 KB, patch)
2016-05-26 16:23 UTC, Matthias Andree
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Omelchuk 2016-05-25 23:30:56 UTC
Updating the ports index ...  Done.
[Updating the portsdb <format:bdb_btree> in /usr/ports ... - 26065 port entries found ...
/usr/ports/INDEX-10:1550:calligra-l10n-: Not in due form: <name>-<version>
/usr/ports/INDEX-10:7291:kde-l10n-: Not in due form: <name>-<version>
/usr/ports/INDEX-10:7293:kde-telepathy-: Not in due form: <name>-<version>
/usr/ports/INDEX-10:7300:kde4-icons-oxygen-: Not in due form: <name>-<version>
/usr/ports/INDEX-10:7311:kdeaccessibility-: Not in due form: <name>-<version>
/usr/ports/INDEX-10:7312:kdeadmin-: Not in due form: <name>-<version>
/usr/ports/INDEX-10:7317:kdegames-: Not in due form: <name>-<version>
/usr/ports/INDEX-10:7322:kdegraphics-: Not in due form: <name>-<version>
/usr/ports/INDEX-10:7326:kdemultimedia-: Not in due form: <name>-<version>
/usr/ports/INDEX-10:7329:kdenetwork-: Not in due form: <name>-<version>
/usr/ports/INDEX-10:7340:kdetoys-: Not in due form: <name>-<version>
/usr/ports/INDEX-10:7341:kdeutils-: Not in due form: <name>-<version>
/usr/ports/INDEX-10:7607:ksysguardd-: Not in due form: <name>-<version>
/usr/ports/INDEX-10:22728:smokegen-: Not in due form: <name>-<version>


# cat INDEX-10 | cut -d "|" -f 1 | grep -e '-$'
kdeaccessibility-
smokegen-
calligra-l10n-
kdegames-
kdegraphics-
kde-l10n-
kdeutils-
kdemultimedia-
kdenetwork-
kde-telepathy-
kdeadmin-
ksysguardd-
kdetoys-
kde4-icons-oxygen-

For example:
# cat /usr/ports/x11-themes/kde4-icons-oxygen/Makefile 
# $FreeBSD: head/x11-themes/kde4-icons-oxygen/Makefile 415864 2016-05-25 20:56:06Z rene $

PORTNAME=	oxygen
PORTVERSION=	${KDE4_VERSION}
CATEGORIES=	x11-themes kde
MASTER_SITES=	KDE/${KDE4_BRANCH}/${PORTVERSION}/src
PKGNAMEPREFIX=	kde4-icons-
DISTNAME=	${PORTNAME}-icons-${PORTVERSION}
DIST_SUBDIR=	KDE/${PORTVERSION}

MAINTAINER=	kde@FreeBSD.org
COMMENT=	The Oxygen icon theme for KDE

USES=		cmake:outsource tar:xz
INSTALL_TARGET=	install
EXTRACT_AFTER_ARGS=	--exclude '${DISTNAME}/scalable'

.include <bsd.port.mk>


<uname>
FreeBSD 10.3-RELEASE-p3 amd64
Comment 1 Vladimir Omelchuk 2016-05-26 01:25:35 UTC
# pkg version -v
kde4-icons-oxygen-4.14.3           >   succeeds index (index has )
Comment 2 Mathieu Arnold freebsd_committer 2016-05-26 08:42:24 UTC
Over to the one who broke them ?
Comment 3 Rene Ladan freebsd_committer 2016-05-26 08:45:31 UTC
It's on my TODO list.

Perhaps we can make 'make index' more strict so that it complains about broken version numbers?
Comment 4 Matthias Andree freebsd_committer 2016-05-26 16:19:45 UTC
Created attachment 170690 [details]
fix up fallout from r415864 where 14 ports came up with empty PORTVERSION

This patch appears to fix the problem for me and goes along the lines suggested by tcberner on IRC earlier.
Comment 5 Matthias Andree freebsd_committer 2016-05-26 16:23:18 UTC
Created attachment 170691 [details]
DO NOT APPLY -- diffs in comparison to ports HEAD as of r415863

THIS WILL NOT APPLY, DO NOT USE, ONLY READ THIS - only for easier review, this is the diff for these 14 ports against the state before the offending commit 415864.
Comment 6 commit-hook freebsd_committer 2016-05-26 16:26:21 UTC
A commit references this bug:

Author: swills
Date: Thu May 26 16:25:41 UTC 2016
New revision: 415902
URL: https://svnweb.freebsd.org/changeset/ports/415902

Log:
  Add USE_KDE4 so that KDE4_VERSION is defined

  PR:		209756
  Submitted by:	T.C.Berner <tcberner@gmail.com>
  Reported by:	Vladimir Omelchuk <admin@vladiom.com.ua>

Changes:
  head/accessibility/kdeaccessibility4/Makefile
  head/devel/smokegen/Makefile
  head/editors/calligra-l10n/Makefile
  head/games/kdegames4/Makefile
  head/graphics/kdegraphics4/Makefile
  head/misc/kde4-l10n/Makefile
  head/misc/kdeutils4/Makefile
  head/multimedia/kdemultimedia4/Makefile
  head/net/kdenetwork4/Makefile
  head/net-im/kde-telepathy/Makefile
  head/sysutils/kdeadmin4/Makefile
  head/sysutils/ksysguardd/Makefile
  head/x11-clocks/kdetoys4/Makefile
  head/x11-themes/kde4-icons-oxygen/Makefile
Comment 7 Steve Wills freebsd_committer 2016-05-26 16:28:47 UTC
Fix committed.