Created attachment 170794 [details]
This patch to x11/konsole:
* fixes readArguments to get all instead of just the first
* implements readEnvironment of FreeBSD
* fixes handling of %c for remote sessions
* add %U (user@) for remote sessions
* fixes %D to handle symlinked homedirs
This started as a backport of Tobias's patch for konsole and grew a bit. A necessary refactor to compile lead to refactoring everything to fit the surrounding style. While I was at it, I fixed the handling of %D as that had been annoying me for quite some time.
I've tested this with current ports, and also with the situation which will exist after PR #210255 is committed. Only on x86 10.3, though. I'd be nice to have this in now, so it will get picked up by all KDE users when PR #210255 hits.
Testbuilds on 11a, 10.3a OK, 10.3i still ongoing, but fails on 9.3a:
Any ideas ?
The patch is wrong, use Q_NULLPTR instead of nullptr (that is c++11, mandatory from qt 5.7 on).
Matthew, can you change and upload your patch again please ?
I modified the patch, testbuilding on 9.3a right now.
Now fails with:
/wrkdirs/usr/ports/x11/konsole/work/konsole-4.14.3/src/ProcessInfo.cpp: In member function 'virtual bool FreeBSDProcessInfo::readEnvironment(int)':
/wrkdirs/usr/ports/x11/konsole/work/konsole-4.14.3/src/ProcessInfo.cpp:688: error: 'Q_NULLPTR' was not declared in this scope
/wrkdirs/usr/ports/x11/konsole/work/konsole-4.14.3/src/ProcessInfo.cpp:694: error: 'Q_NULLPTR' was not declared in this scope
/wrkdirs/usr/ports/x11/konsole/work/konsole-4.14.3/src/ProcessInfo.cpp:702: error: 'Q_NULLPTR' was not declared in this scope
/wrkdirs/usr/ports/x11/konsole/work/konsole-4.14.3/src/ProcessInfo.cpp:707: error: 'Q_NULLPTR' was not declared in this scope
As far as I can see, there's no Q_NULLPTR definition in /usr/local/include/qt4/,
there only is one in /usr/local/include/qt5/.
Argl :) sorry, forgot about that. Just use 0 instead then or NULL
A commit references this bug:
Date: Thu Jun 16 05:44:05 UTC 2016
New revision: 416950
x11/konsole: misc fixes and improvements
- fixes readArguments to get all instead of just the first
- implements readEnvironment of FreeBSD
- fixes handling of %c for remote sessions
- add %U (user@) for remote sessions
- fixes %D to handle symlinked homedirs
This started as a backport of Tobias's patch from
No need to bump portrevision, pending update from PR#210255 will take
care of that.
Submitted by: email@example.com, Tobias C.Berner <firstname.lastname@example.org> (kde)
Reviewed by: Ralf Nolden <email@example.com> (kde)
Approved by: Adriaan de Groot <firstname.lastname@example.org> (kde)