Bug 209874 - sysutils/backuppc: Modernize Samba dependency
Summary: sysutils/backuppc: Modernize Samba dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rene Ladan
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-05-30 22:19 UTC by Rene Ladan
Modified: 2016-06-21 20:40 UTC (History)
1 user (show)

See Also:
moiseev: maintainer-feedback+


Attachments
patch to modernize Samba dependencies (1.39 KB, patch)
2016-05-30 22:19 UTC, Rene Ladan
no flags Details | Diff
Workaround for Samba 4 smbclient (4.21 KB, patch)
2016-06-12 07:33 UTC, Alexander Moisseev
moiseev: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Ladan freebsd_committer freebsd_triage 2016-05-30 22:19:35 UTC
Created attachment 170845 [details]
patch to modernize Samba dependencies

Both net/samba-nmblookup and net/samba-smbclient are slave ports of net/samba36, which is vulnerable and has expired. Instead of net/samba36, use net/samba44 (or perhaps 42 or 43). Drop the SMBCLIENT option since net/samba44 ships with both the nmblookup and smbclient dependencies by default.

Bump PORTREVISION because the option list changes.
Comment 1 Alexander Moisseev 2016-05-31 06:39:17 UTC
BackupPC has issues with samba 4 client. It is possible to partially workaround them by patching BackupPC, but it is a regression anyway. I believe it would be better to stay with samba36 for now. Is there any chance to have net/samba-smbclient in the ports tree for some time?
Comment 2 Alexander Moisseev 2016-06-12 07:33:35 UTC
Created attachment 171325 [details]
Workaround for Samba 4 smbclient

Add possibility to use Samba 4 smbclient (with limitations).
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-06-21 20:39:42 UTC
A commit references this bug:

Author: rene
Date: Tue Jun 21 20:39:01 UTC 2016
New revision: 417288
URL: https://svnweb.freebsd.org/changeset/ports/417288

Log:
  sysutils/backuppc: add a workaround for users of Samba 4.
  Using Samba 3.6 is still reccommended

  PR:		209874
  Submitted by:	myself, patch by maintainer

Changes:
  head/sysutils/backuppc/Makefile
  head/sysutils/backuppc/files/patch-lib_BackupPC_Xfer_Smb.pm
  head/sysutils/backuppc/files/patch-lib__BackupPC__CGI__View.pm
  head/sysutils/backuppc/files/pkg-message.in