Bug 209912 - [NEW PORT] sysutils/siegfried: Advanced file identification tool written in Go
Summary: [NEW PORT] sysutils/siegfried: Advanced file identification tool written in Go
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nikolai Lifanov
URL:
Keywords: feature, patch
Depends on:
Blocks:
 
Reported: 2016-05-31 21:12 UTC by Steffen
Modified: 2017-01-11 19:23 UTC (History)
1 user (show)

See Also:


Attachments
the new port's shar file (2.54 KB, text/plain)
2016-05-31 21:12 UTC, Steffen
no flags Details
updated shar (1.44 KB, text/plain)
2017-01-11 16:58 UTC, Nikolai Lifanov
no flags Details
updated shar (1.44 KB, text/plain)
2017-01-11 17:02 UTC, Nikolai Lifanov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen 2016-05-31 21:12:21 UTC
Created attachment 170890 [details]
the new port's shar file

Siegfried is an advanced file identification tool written in Go. It is signature-based, implementing the PRONOM file format signatures and freedesktop.org's MIME-info file format signatures.
Comment 1 Nikolai Lifanov freebsd_committer 2017-01-11 15:10:54 UTC
Hi! Can you convert this to USES=go please?
https://www.freebsd.org/doc/en/books/porters-handbook/uses-go.html

You can look at sysutils/node_exporter for an example.
Comment 2 Nikolai Lifanov freebsd_committer 2017-01-11 16:58:06 UTC
Created attachment 178758 [details]
updated shar

This is a draft of a cleaned-up port.
The biggest change is renaming the binary from "siegfried" to "sf",
since this is what upstream documentation references.

Can you take a look at it and let me know if you are OK with it?

There is still one issue: I can't actually update signatures. I get this:
System error: Get : unsupported protocol scheme ""

I spent very little time troubleshooting this, but maybe it's something that upstream can help with.
Comment 3 Nikolai Lifanov freebsd_committer 2017-01-11 17:02:26 UTC
Created attachment 178759 [details]
updated shar

Updating to latest version (1.6.7) fixes the protocol error.
I'm ready to commit this if you are okay with how it looks.
Comment 4 Steffen 2017-01-11 17:09:58 UTC
(In reply to Nikolai Lifanov from comment #3)
I am ok with it!
Comment 5 commit-hook freebsd_committer 2017-01-11 19:22:40 UTC
A commit references this bug:

Author: lifanov
Date: Wed Jan 11 19:22:30 UTC 2017
New revision: 431196
URL: https://svnweb.freebsd.org/changeset/ports/431196

Log:
  new port: sysutils/siegfried

  Siegfried is an advanced file identification tool written in Go.
  It is signature-based, implementing the PRONOM file format signatures
  and freedesktop.org's MIME-info file format signatures.

  PR:		209912
  Submitted by:	Steffen Fritz <steffen@fritz.wtf>
  Reviewed by:	matthew
  Approved by:	matthew (mentor)
  Differential Revision:	https://reviews.freebsd.org/D9136

Changes:
  head/sysutils/Makefile
  head/sysutils/siegfried/
  head/sysutils/siegfried/Makefile
  head/sysutils/siegfried/distinfo
  head/sysutils/siegfried/pkg-descr
  head/sysutils/siegfried/pkg-message
Comment 6 Nikolai Lifanov freebsd_committer 2017-01-11 19:23:43 UTC
Committed with changes, thanks!