Bug 210100 - archivers/gtar does not build
Summary: archivers/gtar does not build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Christian Weisgerber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-07 13:59 UTC by Victor Sudakov
Modified: 2016-06-09 11:21 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (naddy)


Attachments
Poudriere log. (130.84 KB, text/x-log)
2016-06-07 13:59 UTC, Victor Sudakov
no flags Details
patch-po_Makefile.in.in (986 bytes, patch)
2016-06-08 15:40 UTC, Christian Weisgerber
no flags Details | Diff
gtar.patch (986 bytes, patch)
2016-06-09 10:14 UTC, Christian Weisgerber
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Sudakov 2016-06-07 13:59:43 UTC
Created attachment 171145 [details]
Poudriere log.

cc -std=gnu99   -O2 -pipe -fstack-protector -fno-strict-aliasing  -L/usr/local/lib -fstack-protector -o tar buffer.o checkpoint.o  compare.o create.o delete.o  exit.o exclist.o extract.o  xheader.o incremen.o list.o  map.o misc.o names.o sparse.o  suffix.o system.o tar.o  transform.o unlink.o update.o  utf8.o warning.o xattrs.o  ../lib/libtar.a ../gnu/libgnu.a  /usr/local/lib/libiconv.so -Wl,-rpath -Wl,/usr/local/lib    
Making all in scripts
Making all in po
Error expanding embedded variable.
*** [all-recursive] Error code 1

Stop in /wrkdirs/usr/ports/archivers/gtar/work/tar-1.29.
*** [all] Error code 1

Stop in /wrkdirs/usr/ports/archivers/gtar/work/tar-1.29.
*** [do-build] Error code 1

Stop in /usr/ports/archivers/gtar.
====>> Cleaning up wrkdir
===>  Cleaning for gtar-1.29
build of archivers/gtar ended at Mon Jun  6 23:21:33 KRAT 2016
build time: 00:00:48
!!! build failure encountered !!!

Complete poudriere log is attached.
Comment 1 Christian Weisgerber freebsd_committer freebsd_triage 2016-06-08 15:40:54 UTC
Created attachment 171209 [details]
patch-po_Makefile.in.in

The problem is most likely an instance of this:
http://docs.freebsd.org/cgi/mid.cgi?slrnmvro62.94q.naddy

Does this patch fix it?
Comment 2 Victor Sudakov 2016-06-09 05:42:42 UTC
I put your patch as /var/poudriere/ports/default/archivers/gtar/files/patch-po_Makefile.in.in but the problem persists. Maybe the patch file itself is garbled?
Comment 3 Victor Sudakov 2016-06-09 05:56:27 UTC
I have tried adding manually "PO_DEPENDS_ON_POT =" into /wrkdirs/usr/ports/archivers/gtar/work/tar-1.29/po/Makefile.in.in to no avail:



root@93amd64-default:/usr/ports/archivers/gtar #
root@93amd64-default:/usr/ports/archivers/gtar # !grep
grep PO_DEPENDS_ON_POT /wrkdirs/usr/ports/archivers/gtar/work/tar-1.29/po/Makefile.in.in
PO_DEPENDS_ON_POT =
POFILESDEPS = $(POFILESDEPS_$(PO_DEPENDS_ON_POT))
root@93amd64-default:/usr/ports/archivers/gtar # make
===>  Building for gtar-1.29
/usr/bin/make  all-recursive
Making all in doc
Making all in gnu
/usr/bin/make  all-recursive
Making all in lib
/usr/bin/make  all-am
Making all in rmt
Making all in src
Making all in scripts
Making all in po
Error expanding embedded variable.
*** [all-recursive] Error code 1
1 error
*** [all] Error code 2
1 error
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** [do-build] Error code 1

Stop in /usr/ports/archivers/gtar.
root@93amd64-default:/usr/ports/archivers/gtar #
Comment 4 Christian Weisgerber freebsd_committer freebsd_triage 2016-06-09 10:14:48 UTC
Created attachment 171227 [details]
gtar.patch

Sorry, I mislabeled the patch.  It needs to be applied to the port.

(If you manually patch po/Makefile.in.in, this needs to be done BEFORE running make configure.)
Comment 5 Victor Sudakov 2016-06-09 10:43:36 UTC
(In reply to Christian Weisgerber from comment #4)
Yes, this new patch fixes the issue.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-06-09 11:13:47 UTC
A commit references this bug:

Author: naddy
Date: Thu Jun  9 11:13:10 UTC 2016
New revision: 416591
URL: https://svnweb.freebsd.org/changeset/ports/416591

Log:
  Work around a bug in FreeBSD 9 make(1).
  http://docs.freebsd.org/cgi/mid.cgi?slrnmvro62.94q.naddy

  PR:		210100
  Reported by:	vas@mpeks.tomsk.su

Changes:
  head/archivers/gtar/files/patch-po_Makefile.in.in