Bug 210107 - editors/plume-creator-devel: Remove wrongly used PLIST_SUB from pkg-plist
Summary: editors/plume-creator-devel: Remove wrongly used PLIST_SUB from pkg-plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-06-07 16:53 UTC by Tobias Berner
Modified: 2016-06-12 10:07 UTC (History)
2 users (show)

See Also:
vlad-fbsd: maintainer-feedback+


Attachments
s#%%QT_BINDIR%%#bin#g (447 bytes, patch)
2016-06-07 16:53 UTC, Tobias Berner
vlad-fbsd: maintainer-approval? (yamagi)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Berner 2016-06-07 16:53:20 UTC
Created attachment 171155 [details]
s#%%QT_BINDIR%%#bin#g

editors/plume-creator-devel uses the substitution %%QT_BINDIR%% [=relative path to Qt binaries] by mistake.
The attached patch replaces this everywhere by "bin".
Comment 1 yamagi 2016-06-11 08:27:25 UTC
Comment on attachment 171155 [details]
s#%%QT_BINDIR%%#bin#g

This looks good. Go ahead! :)
Comment 2 VK freebsd_triage 2016-06-11 14:29:29 UTC
yamagi@, thanks for the feedback. Please help us track the issues more efficiently by flagging your feedback as maintainer, with maintainer-feedback+. ;)
Comment 3 VK freebsd_triage 2016-06-11 14:30:29 UTC
Comment on attachment 171155 [details]
s#%%QT_BINDIR%%#bin#g

Please flag the patch with maintainer-approval+, so it can appear in the Maintainer Approved saved search.
Comment 4 yamagi 2016-06-11 18:50:08 UTC
Apparently I'm unable to set the maintainer-approval flag. I've tried it 3 times, even with uBlock Origin disabled. Details -> maintainer-approval -> + -> Submit. And it still doesn't show up. Am I too stupid or I'm hitting some strange Bugzilla problem?
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2016-06-12 10:07:27 UTC
Fixed.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-06-12 10:07:29 UTC
A commit references this bug:

Author: pi
Date: Sun Jun 12 10:07:17 UTC 2016
New revision: 416787
URL: https://svnweb.freebsd.org/changeset/ports/416787

Log:
  editors/plume-creator-devel: Remove wrongly used PLIST_SUB from pkg-plist

  PR:		210107
  Submitted by:	Tobias C.Berner <tcberner@gmail.com> (kde)

Changes:
  head/editors/plume-creator-devel/pkg-plist