Bug 210154 - devel/linux_kdump: has become unnecessary on 11.0-CURRENT
Summary: devel/linux_kdump: has become unnecessary on 11.0-CURRENT
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-emulation (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-09 02:41 UTC by Johannes Jost Meixner
Modified: 2017-02-26 21:19 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (emulation)

Attachments
mark linux_kdump ignored on freebsd > 1100092 (554 bytes, patch)
2016-06-09 02:41 UTC, Johannes Jost Meixner 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Jost Meixner freebsd_committer freebsd_triage 2016-06-09 02:41:59 UTC 
Created attachment 171223 [details]
mark linux_kdump ignored on freebsd > 1100092

With the work done in https://svnweb.freebsd.org/base?view=revision&revision=292622, using devel/linux_kdump is unnecessary on any FreeBSD version later than 1100092.

Mark it ignored to make users aware of kdump(1). While there, bump the version...
Comment 1 John Baldwin freebsd_committer freebsd_triage 2016-06-14 18:21:54 UTC 
Actually, this commit is the one which teaches native kdump how to handle traces from Linux binaries:

https://svnweb.freebsd.org/base?view=revision&revision=283430

My commit just broke the build of linux_kdump.  Going forward any work to add decoding of system call arguments for Linux binaries should happen in-tree rather than in the port though.
Comment 2 Dmitry Chagin freebsd_committer freebsd_triage 2016-06-15 16:35:00 UTC 
(In reply to John Baldwin from comment #1)
So, no one will oppose if I adapt some code from linux_kdump to in tree kdump? syscall and ioctl decoding code
Comment 3 John Baldwin freebsd_committer freebsd_triage 2016-06-15 17:10:15 UTC 
No.  We should perhaps refactor kdump.c a bit so it doesn't become too large, but truss already includes support for decoding some Linux system calls as well.  I should probably finish my WIP of moving the mksubr-generated tables into libsysdecode (so they are shared with truss) as that might make it easier for you to add decoding of Linux system calls in both places (truss and kdump).
Comment 4 Dmitry Chagin freebsd_committer freebsd_triage 2016-06-15 17:40:06 UTC 
(In reply to John Baldwin from comment #3)
Ok, ping me please when it will be ready :)
Comment 5 John Baldwin freebsd_committer freebsd_triage 2016-10-20 21:51:43 UTC 
(In reply to Dmitry Chagin from comment #4)
FYI, I've committed the pending mksubr refactoring I had to libsysdecode.  For adding new decoding tables, please add them in libsysdecode and then make use of them in truss and/or kdump.
Comment 6 Tijl Coosemans freebsd_committer freebsd_triage 2017-02-26 21:19:00 UTC 
The port has been removed.