Created attachment 171398 [details]
This will allow ZM to build under CURRENT.
Tested in poudriere against 11amd64, 10amd64, 10i386
Created attachment 171399 [details]
I meet a problem trying to build this patched port on FreeBSD 9.3 i386 (it build on head-amd64).
My failed poudriere testport log is here:
Can you check if it build on your side ?
ZM not compiles under 93i386 yet, this patch doesn't affect it in any way. I hope to fix it as well.
Then can you add some:
BROKEN_FreeBSD_9_i386= does not build on i386 FreeBSD 9.x
to the makefile ?
Created attachment 171465 [details]
compiles under 93-i386
With this new patch it works on 9.3-i386 and head-amd64.
But I've just notice 2 problems I didn't see before:
First, the Makefile needs this line for announcing it's a new "port only but not sofware" version:
Second, "poudriere testport" generate these warning :
====> Running Q/A tests (stage-qa)
Error: /usr/local/bin/zma is linked to /usr/local/lib/libcurl.so.4 from ftp/curl but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libcurl.so:ftp/curl
Error: /usr/local/bin/zma is linked to /usr/local/lib/libgnutls.so.30 from security/gnutls but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libgnutls.so:security/gnutls
Do you think these warning are false alarm or true warning ?
1. It's a not the new port either. :) This patch allows it to build, so, those lucky enough who built it don't need to rebuild it and those who have the issue don't have port at all.
2. ZM use cmake with autodetection. These components are optional and untested by me. curl and gnutls are used to fetch stream from remote cameras, however there are 2 backends capable to do the same - ZM core and ffmpeg I left enabled. As I try to keep footprint as small as possible, I don't enable it. poudriere fetched it for deps as it uses default flags, so they are silently linked.
Conclusion is: falsa alarm until someone will ask for these backends.
Olivier, can you commit it ?
I've "pre-commit" it 15th June:
But It need to be accepted by my mentors before to be accepted: When a newbie like me take care of a patch, there is little latency (mentor review) before to be committed.
No problem, just to be sure that this one is not forgotten - pkg-fallout hammering my email with build failures :)
A commit references this bug:
Date: Mon Jun 20 08:06:47 UTC 2016
New revision: 417142
Fix multimedia/zoneminder build on 9.3-i386 and head-amd64
Submitted by: email@example.com
Approved by: jadawin
Differential Revision: https://reviews.freebsd.org/D6854
Thanks for your patch.