Bug 210400 - [maintainer][patch] www/node: remove erroneous post-configure step
Summary: [maintainer][patch] www/node: remove erroneous post-configure step
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Adam Weinberger
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-06-20 06:57 UTC by Bradley T. Hughes
Modified: 2016-06-20 20:10 UTC (History)
1 user (show)

See Also:

Attachments
patch from git, apply with patch -p1 (415 bytes, patch)
2016-06-20 06:57 UTC, Bradley T. Hughes 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bradley T. Hughes freebsd_committer freebsd_triage 2016-06-20 06:57:41 UTC 
Created attachment 171595 [details]
patch from git, apply with patch -p1

An erroneous post-configure step snuck into the www/node/Makefile after the last PR before I could review the patch. This patch removes it.
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2016-06-20 19:00:39 UTC 
I haven't had a chance to look at the source yet. Do you know whether that patch had any basis?

In general we don't want /usr/local hardcoded. Does it need to be subbed s|/usr/local|${LOCALBASE| ?
Comment 2 Bradley T. Hughes freebsd_committer freebsd_triage 2016-06-20 19:38:23 UTC 
I think the basis was to try and remove the -I/usr/local/include that had been causing the problem. Personally, I feel that patching generated output isn't the right way to fix this... it feels too brittle and heavy handed.

I'd rather find out how to make the upstream configure generate the right output. If we cannot do that, I'd like to patch the generator itself, and submit those patches upstream.

FWIW, /usr/local is not hardcoded anywhere in the port. The /usr/local/* paths are getting pulled in via pkgconfig.
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2016-06-20 20:10:18 UTC 
Committed. Thanks, Bradley.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-06-20 20:10:34 UTC 
A commit references this bug:

Author: adamw
Date: Mon Jun 20 20:09:53 UTC 2016
New revision: 417178
URL: https://svnweb.freebsd.org/changeset/ports/417178

Log:
  Revert part of r417063 that wasn't supposed to be committed. It
  removed a -I/usr/local/include, but it's present elsewhere in the
  CFLAGS so it doesn't change the final product.

  PR:		210400
  Submitted by:	maintainer (Bradley T. Hughes)

Changes:
  head/www/node/Makefile