Bug 210426 - www/node: Does not compile with BUNDLED_SSL enabled and LibreSSL installed
Summary: www/node: Does not compile with BUNDLED_SSL enabled and LibreSSL installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on: 210618
Blocks:
  Show dependency tree / graph
 
Reported: 2016-06-21 04:06 UTC by Victor
Modified: 2016-06-30 07:18 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (bhughes)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor 2016-06-21 04:06:10 UTC 
The port fails to build with BUNDLED_SSL enabled and LibreSSL installed. However, it builds with BUNDLED_SSL enabled if LibreSSL is not on the system, or if security/openssl is installed.
Comment 1 Walter Schwarzenfeld 2016-06-21 04:39:10 UTC 
Look at the Makefile:

.if empty(PORT_OPTIONS:MBUNDLED_SSL)
.if defined(OPENSSL_PORT) && (${OPENSSL_PORT} == "security/libressl" || ${OPENSSL_PORT} == "security/libressl-devel")
IGNORE=         cannot build node.js with LibreSSL. You must enable BUNDLED_SSL
.endif
.endif
Comment 2 Victor 2016-06-21 04:57:24 UTC 
(In reply to w.schwarzenfeld from comment #1)

Yes, the build fails with BUNDLED_SSL enabled as per that warning.
Comment 3 Walter Schwarzenfeld 2016-06-21 05:40:47 UTC 
I think the conditional should
changed from
.if defined(OPENSSL_PORT) && (${OPENSSL_PORT} == "security/libressl" || ${OPENSSL_PORT} == "security/libressl-devel")

to
.if (${SSL_DEFAULT} == "libressl" || ${SSL_DEFAULT} == "libressl-devel")
Comment 4 Bradley T. Hughes freebsd_committer freebsd_triage 2016-06-29 07:30:04 UTC 
FYI, I have a patch that should fix this in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210618. Thanks for the report. :)
Comment 5 Victor 2016-06-30 07:18:25 UTC 
Closing; maintainer fixed issue per bug #210618. Port now builds under specified conditions.

Thanks!