Bug 210428 - x11/keyboardcast: switch to github
Summary: x11/keyboardcast: switch to github
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-21 10:18 UTC by ekoort
Modified: 2016-06-24 16:02 UTC (History)
1 user (show)

See Also:

Attachments
switch to github (1.17 KB, text/plain)
2016-06-21 10:18 UTC, ekoort 		no flags Details
new patch (1.21 KB, patch)
2016-06-21 14:00 UTC, ekoort 		no flags Details | Diff
reorganized new patch (1.17 KB, patch)
2016-06-23 11:53 UTC, ekoort 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ekoort 2016-06-21 10:18:21 UTC 
Created attachment 171640 [details]
switch to github

No functional changes at the moment. Source is moved to Github.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-06-21 13:27:47 UTC 
The patch does not apply, it has CRLF line terminators. Does not apply even if they're fixed. Also, please check the port with portlint before submission. For instance,
- you should use tabs instead of spaces
- MASTER_SITES not needed (provided by USE_GITHUB)
- GH_PROJECT not needed (defaults to portname)
- DISVERSIONPREFIX belongs after PORTVERSION line
- USE_GITHUB/GH_ACCOUNT block belongs after MAINTAINER/COMMENT block
Comment 2 ekoort 2016-06-21 14:00:14 UTC 
Created attachment 171644 [details]
new patch

Sorry about previous patch. 
I copy-pasted this multiple times before in various editors/environments. 
So new patch is result of 
# diff -ruN keyboardcast keyboardcast.orig > keyboardcast.txt
Also used portlint. I hope it works this time.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2016-06-23 11:10:01 UTC 
(In reply to eimar.koort from comment #2)

The patch now applies, but problems I've mentioned were not fixed.
Comment 4 ekoort 2016-06-23 11:53:37 UTC 
Created attachment 171709 [details]
reorganized new patch

Hi. Thank You for your patience. 
Here is new portlinted and reorganized patch.
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2016-06-24 16:02:45 UTC 
Now perfect, thank you!
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-06-24 16:02:57 UTC 
A commit references this bug:

Author: amdmi3
Date: Fri Jun 24 16:02:30 UTC 2016
New revision: 417437
URL: https://svnweb.freebsd.org/changeset/ports/417437

Log:
  - Switch port to new GitHub home
  - While here, add LICENSE

  PR:		210428
  Submitted by:	eimar.koort@gmail.com (maintainer)

Changes:
  head/x11/keyboardcast/Makefile
  head/x11/keyboardcast/distinfo