Bug 210441 - ftp/wget build fails with unresolved iconv references [patch]
Summary: ftp/wget build fails with unresolved iconv references [patch]
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vasil Dimov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-06-21 18:30 UTC by Helge Oldach
Modified: 2016-06-24 17:09 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (vd)


Attachments
Patch (376 bytes, patch)
2016-06-21 18:33 UTC, Helge Oldach
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Helge Oldach 2016-06-21 18:30:03 UTC
Building fails with unresolved iconv references:

  CC       ftp-opie.o
  CC       openssl.o
  CC       http-ntlm.o
  CC       version.o
  CCLD     wget
url.o: In function `url_file_name':
url.c:(.text+0x278a): undefined reference to `libiconv_open'
url.c:(.text+0x283c): undefined reference to `libiconv'
url.c:(.text+0x2861): undefined reference to `libiconv'
url.c:(.text+0x293a): undefined reference to `libiconv_close'
url.c:(.text+0x29d8): undefined reference to `libiconv_close'
cc: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[5]: *** [Makefile:1501: wget] Error 1
gmake[5]: Leaving directory '/usr/obj/usr/ports/ftp/wget/work/wget-1.18/src'
gmake[4]: *** [Makefile:1400: all] Error 2
gmake[4]: Leaving directory '/usr/obj/usr/ports/ftp/wget/work/wget-1.18/src'
gmake[3]: *** [Makefile:1408: all-recursive] Error 1
gmake[3]: Leaving directory '/usr/obj/usr/ports/ftp/wget/work/wget-1.18'
gmake[2]: *** [Makefile:1364: all] Error 2
gmake[2]: Leaving directory '/usr/obj/usr/ports/ftp/wget/work/wget-1.18'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/ftp/wget
*** Error code 1

Stop.
make: stopped in /usr/ports/ftp/wget
Comment 1 Helge Oldach 2016-06-21 18:33:53 UTC
Created attachment 171654 [details]
Patch
Comment 2 Helge Oldach 2016-06-21 18:36:48 UTC
I suspect it works fine with NLS or IDN options enabled, as they rely on iconv anyhow. Probably the maintainer has one of these enabled.

Since we have iconv in recent 10-STABLE base systems, just add USES=iconv which will do the needful. See patch.
Comment 3 Vasil Dimov freebsd_committer 2016-06-21 19:53:25 UTC
Committed, thanks!
Comment 4 commit-hook freebsd_committer 2016-06-21 19:53:37 UTC
A commit references this bug:

Author: vd
Date: Tue Jun 21 19:52:42 UTC 2016
New revision: 417282
URL: https://svnweb.freebsd.org/changeset/ports/417282

Log:
  ftp/wget: fix compilation when IDN and NLS are disabled

  PR:		210441
  Submitted by:	Helge Oldach <freebsd@oldach.net>

Changes:
  head/ftp/wget/Makefile
Comment 5 commit-hook freebsd_committer 2016-06-24 17:09:06 UTC
A commit references this bug:

Author: vd
Date: Fri Jun 24 17:08:43 UTC 2016
New revision: 417438
URL: https://svnweb.freebsd.org/changeset/ports/417438

Log:
  MFH: r417188 r417282 r417417

  ftp/wget: Upgrade from 1.16.3_1 to 1.18

  PR:		210421 [1], 210512
  Submitted by:	Vladimir Krstulja <vlad-fbsd@acheronmedia.com> [1]
  Security:	CVE-2016-4971

  ftp/wget: fix compilation when IDN and NLS are disabled

  PR:		210441
  Submitted by:	Helge Oldach <freebsd@oldach.net>

  Change AUTHOR: entry in UPDATING to committer

  Suggested by:	koobs@

  Approved by:	ports-secteam

Changes:
_U  branches/2016Q2/
  branches/2016Q2/UPDATING
  branches/2016Q2/ftp/wget/Makefile
  branches/2016Q2/ftp/wget/distinfo