Bug 210449 - [PATCH]]benchmarks/iozone fails build
Summary: [PATCH]]benchmarks/iozone fails build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-06-21 22:48 UTC by Walter Schwarzenfeld
Modified: 2016-06-22 18:30 UTC (History)
1 user (show)

See Also:


Attachments
patch-benchmarks-iozone (3.02 KB, patch)
2016-06-21 22:48 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Schwarzenfeld freebsd_triage 2016-06-21 22:48:36 UTC
Created attachment 171659 [details]
patch-benchmarks-iozone

Benchmarks/iozone(3-434) fails to build:
###
<...snip...>
iozone.c:1297:1: error: unknown type name 'off64_t'; did you mean 'off_t'?
off64_t offset = 0;               /*offset for random I/O */
^~~~~~~
off_t
/usr/include/sys/types.h:173:18: note: 'off_t' declared here
typedef __off_t         off_t;          /* file offset */
                        ^
iozone.c:1298:1: error: unknown type name 'off64_t'; did you mean 'off_t'?
off64_t offset64 = 0;               /*offset for random I/O */
^~~~~~~
off_t
/usr/include/sys/types.h:173:18: note: 'off_t' declared here
typedef __off_t         off_t;          /* file offset */
                        ^
iozone.c:1299:1: error: unknown type name 'off64_t'; did you mean 'off_t'?
off64_t filebytes64;

https://lists.freebsd.org/pipermail/freebsd-ports/2016-June/103634.html

It builds if I removed files/patch-iozone.c files/libasync.c.
(There are still warnings). But tested quickly functionallity, and this will work.
Not sure if all will work.
Comment 1 Walter Schwarzenfeld freebsd_triage 2016-06-21 23:17:52 UTC
Poudrietestbuilds: Builds fine with 103am64, 93amd64, 103i386, 93i386.
Comment 2 commit-hook freebsd_committer 2016-06-22 17:31:11 UTC
A commit references this bug:

Author: mi
Date: Wed Jun 22 17:30:57 UTC 2016
New revision: 417327
URL: https://svnweb.freebsd.org/changeset/ports/417327

Log:
  Ensure clean build with clang on both amd64 and i386. Respect the
  SSH-option turned off (rsh was replaced with ssh unconditionally).

  PR:		210449

Changes:
  head/benchmarks/iozone/files/patch-iozone.c
  head/benchmarks/iozone/files/patch-libasync.c
  head/benchmarks/iozone/files/patch-pit_server.c
Comment 3 Mikhail Teterin freebsd_committer 2016-06-22 17:32:37 UTC
Could you confirm, that the just-committed change fixes the problem -- and the warnings -- for you? Thanks!
Comment 4 Walter Schwarzenfeld freebsd_triage 2016-06-22 18:02:17 UTC
Yes, i confirm. Thank you!