Bug 210508 - security/py-certbot: rename of port incomplete
Summary: security/py-certbot: rename of port incomplete
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bernard Spil
URL:
Keywords: easy, needs-patch
Depends on:
Blocks:
 
Reported: 2016-06-24 05:42 UTC by Remko Lodder
Modified: 2016-06-24 21:22 UTC (History)
0 users

See Also:
koobs: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Remko Lodder freebsd_committer 2016-06-24 05:42:40 UTC
Hi there,

You have recently updated the letsencrypt software to use a new name.

It was called letsencrypt, like the command itself was named like that as well. It had been renamed to certbot, but the examples still use 'letsencrypt' (like pkg-message).

In addition, if you use the 'certbot' command standalone, you will get a help message that states;

$ certbot
No installers are available on your OS yet; try running "letsencrypt-auto certonly" to get a cert you can install manually

which also still mentions letsencrypt-auto in this case. Is this something we can change or ask upstream to clarify?

Would it be wise to have an entry in UPDATING so that people know that the commands change, and perhaps instruct on how to have a clean upgrade?

Thanks in advance, and thanks for your work! It is appreciated :)
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-06-24 05:51:01 UTC
Over to last committer

Remko, if you have proposals for changes in mind, please feel free to attach a patch

Thank you for the report
Comment 2 Remko Lodder freebsd_committer 2016-06-24 05:55:23 UTC
(In reply to Kubilay Kocak from comment #1)

I'll leave that at the discretion of the committer. I do not have the time nor wish to generate patches. I do think that an UPDATING entry should have been placed with this rename.

Something in the lines of:

Rename py-letsencrypt to py-certbot to follow the official name change. To upgrade your software use ``pkg set -o security/py-letsencrypt:security/py-certbot py27-letsencrypt´'.

Please update all your scripts, applications, cronjobs and such to use the 'certbot' application.

... or something similiar.

thanks,
Remko
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-06-24 06:08:49 UTC
Thank feedback should be sufficient, thank you Remko
Comment 4 commit-hook freebsd_committer 2016-06-24 21:21:29 UTC
A commit references this bug:

Author: brnrd
Date: Fri Jun 24 21:21:08 UTC 2016
New revision: 417447
URL: https://svnweb.freebsd.org/changeset/ports/417447

Log:
  security/py-certbot: Complete renaming from letsencrypt

    - Rename relevant occurences in pkg-descr and pkg-message

  PR:		210508

Changes:
  head/security/py-certbot/pkg-descr
  head/security/py-certbot/pkg-message
Comment 5 Bernard Spil freebsd_committer 2016-06-24 21:22:46 UTC
The review I had created contained an UPDATING entry. Feedback from portmgr was that `pkg` takes care of this and renames don't require an UPDATING entry.