The update of net/libvncserver to 0.9.10 succeds with poudriere but fails in the port with:
in file included from rfbproto.c:2406:
./h264.c:253:108: error: too few arguments to function call, expected 8, have 6
va_status = vaCreateSurfaces(va_dpy, width, height, VA_RT_FORMAT_YUV420, SURFACE_NUM, &va_surface_id);
/usr/local/include/va/va.h:945:1: note: 'vaCreateSurfaces' declared here
I made a "testpatch" to eliminate "too few arguments to function call, expected 8, have 6".
(I don't attach this patch, cause it is surely wrong).
After this it compiled,but shows error message like this:
In file included from gtkvncviewer.c:27:
In file included from /usr/local/include/gtk-2.0/gdk/gdkx.h:33:
In file included from /usr/local/include/X11/Xutil.h:54:
In file included from /usr/local/include/X11/keysym.h:73:
/usr/local/include/X11/keysymdef.h:1332:9: warning: 'XK_Greek_omega' macro redefined
#define XK_Greek_omega 0x07f9 /* U+03C9 GREEK SMALL LETTER OMEGA */
so I guess it don't uses the headers from the port, it use the system headers - and this seems wrong.
Port is unmaintained.
Yes, it fails to build with libva support.
As a workaround you can disable it.
Add this line
Thanks! That works!
As Carlos said, I believe this is because the environment you are building in has libva and GTK installed (perhaps the former only after adding it to LIB_DEPENDS). A poudriere build uses a clean environment which does not have either of these, so when they are checked for in the configure and not found, the configure is disabling the build for the H.264 encodings and the GTK+ vnc viewer example respectively.
It seems like perhaps we need to either add LIBVA and GTK as options or dependencies, and if they are enabled we will run into the compile problems you are experiencing.
Created attachment 171765 [details]
The following patch fix the issue.
This patch makes h264.c compile with recent libva version by including va_compat.h
Thanks for reporting this Walter, and Carlos thanks very much for the patch.
A fix for this bug is being prepared here:
Committed. Thanks again to Walter and Carlos.
A commit references this bug:
Date: Sun Jun 26 22:25:52 UTC 2016
New revision: 417620
net/libvncserver: Fix build with libva
- Add new option to select whether to compile with VAAPI support,
so that if multimedia/libva is already installed on the system
during the build process, it is not linked to unless desired.
- Add patch to allow h.264 support to build using libva deprecated API
Submitted by: cpm
Reported by: Walter Schwarzenfeld <email@example.com>
Approved by: adamw (mentor)
Differential Revision: https://reviews.freebsd.org/D6974
Should the quarterly branch receive this bug fix?
(In reply to Kubilay Kocak from comment #9)
> Should the quarterly branch receive this bug fix?
No, because the bug was only introduced during the recent update of net/libvncserver to 0.9.10 on 24th June 2016.