Bug 210567 - www/lessc: building is occurring in stage phase, this is incorrect
Summary: www/lessc: building is occurring in stage phase, this is incorrect
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-25 10:06 UTC by John Marino
Modified: 2016-08-27 21:35 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (rodrigo)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer freebsd_triage 2016-06-25 10:06:40 UTC
I don't know anything about npm, but it appears to be both building and installing in one step.

-----
do-install:
	(cd ${STAGEDIR}${PREFIX}/lib ; ${SETENV} HOME=${WRKDIR} npm install ${WRKSRC})
	# this is a dirty hack
	${LN} -s ${PREFIX}/lib/node_modules/.bin/lessc ${STAGEDIR}${PREFIX}/bin/lessc
-----

I would think this needs to be broken into two steps, e.g. convert do-install to do-build and install it in a temporary location, and then add a new do-install that copies it to the stage directory.   There should be no building at all during the stage phase ideally, only copying.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-08-27 21:35:04 UTC
A commit references this bug:

Author: marino
Date: Sat Aug 27 21:34:27 UTC 2016
New revision: 420999
URL: https://svnweb.freebsd.org/changeset/ports/420999

Log:
  www/lessc: Moving building out of stage phase, fix stage-QA

  This port would build and install in the stage phase, but building is
  supposed to be complete by then.  Moreover, stage QA checks complain
  about thousands of "orphaned" files and symbolic links with absolute
  paths.  Fix all the problems by installing in a temporary build directory
  and moving just the lessc files over the stage directory, and fix the
  symbolic link by defining a relative path instead.

  Functionally, the new package is the same as the old one, so no revbump
  is required.

  PR:		210567
  Approved by:	maintainer timeout (2 months)

Changes:
  head/www/lessc/Makefile