Bug 210601 - sysutils/heartbeat: PID file is part of pkg
Summary: sysutils/heartbeat: PID file is part of pkg
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-26 21:44 UTC by Michael Gmelin
Modified: 2016-08-16 17:23 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (ports)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Gmelin freebsd_committer freebsd_triage 2016-06-26 21:44:11 UTC
The package includes /var/run/heartbeat.pid, which is rewritten every time heartbeat starts. As a result, pkg check -s always reports this file having a modified checksum.

# pkg which /var/run/heartbeat.pid 
/var/run/heartbeat.pid was installed by package heartbeat-2.1.4_27
# pkg check -s heartbeat
Checking heartbeat:   0%
heartbeat-2.1.4_27: checksum mismatch for /var/run/heartbeat.pid
Checking heartbeat: 100%
Comment 1 John Marino freebsd_committer freebsd_triage 2016-08-15 17:04:28 UTC
Michael,
It appears the maintainer is not responding.  How about providing a _tested_ patch and we can just commit it?
Comment 2 Michael Gmelin freebsd_committer freebsd_triage 2016-08-16 16:53:01 UTC
Hi John,
Thanks for reminding me of this. I was mostly looking for maintainer feedback, as the Makefile explicitly states:

${TOUCH} ${STAGEDIR}/var/run/heartbeat.pid

on post-install.

I'll do some research if there is any specific reason why this is done, if there isn't, I'll commit a tested patch.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-08-16 17:14:05 UTC
A commit references this bug:

Author: grembo
Date: Tue Aug 16 17:13:30 UTC 2016
New revision: 420291
URL: https://svnweb.freebsd.org/changeset/ports/420291

Log:
  Remove pid file that was added by accident when stagifying the port.

  PR:		210601
  Approved by:	mentors (implicit)

Changes:
  head/sysutils/heartbeat/Makefile
  head/sysutils/heartbeat/pkg-plist