The patch adds the following features to the lang/rust port: * Adds support for DOCS option * Adds a SRCS option, since compiler sources are needed at runtime for some rust applications, such as the rust racer debugger Consequently, I will submit a port for devel/racer shortly. Tim
Created attachment 171856 [details] add DOCS and SRCS options Compressed as tar.bz2 to fit in space usage requirement of less than 1 mb.
My apologies, I meant, bz2, not tarball.
I just submitted a port for autocomplete utility devel/racer, which is dependent on this patch, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210614 for more details. This submission is in fact a patch inside the bz2 file, just that the OPTIONS implemented by this patch make the pkg-plist rather large, although I do not believe it will make it much harder to maintain. Let me know if there is some way that I can address any concerns with the submission if it does not follow conventions closely.
Should I Cc: the port maintainer, or is the maintainer-feedback flag sufficient notification?
Looking into it as soon as I can
(In reply to Timothy Beyer from comment #3) Including DOCS into the rust port is a good idea, but I think it might be better to bundle the sources in a separate port. That way, any dependent port can specify if it needs only the runtime components (probably the majority of cases) or if it needs the sources as well. Let me know if I miss something critical with this idea.
New proposed patch via https://reviews.freebsd.org/D7050 Now waiting for verification / identification of breaking changes in lang/rust-nightly or DragonFlyBSD.
I agree that a separate port makes more sense for installing the sources, and I can understand any hesitation to that option, since it could potentially make the port harder to maintain in the future, especially given that rust changes so rapidly. The only thing that worries me about a separate port is that could potentially suffer from one of two problems, depending on which way it is implemented: 1. If it is completely separate, then the hypothetical lang/rust-sources port might install sources for a different version than the lang/rust port, which is unintuitive 2. If it is a metaport, then any updates to the lang/rust port will break the hypothetical lang/rust-sources port due to incorrect pkg-plist (if someone knows a good way to do this without breakage when the main port changes, then I would support it) There might be a better way to do this, but right now, I'm leaning more towards the first method, to ease maintenance burden, as I'm not good at maintaining ports that change often. Regards, Tim
A commit references this bug: Author: riggs Date: Sat Jul 2 19:06:35 UTC 2016 New revision: 417938 URL: https://svnweb.freebsd.org/changeset/ports/417938 Log: Add DOCS OPTION for html docs, bump PORTREVISION PR: 210613 Reported by: beyert@cs.ucr.edu Reviewed by: riggs, marino, jbeich Differential Revision: https://reviews.freebsd.org/D7050 Changes: head/lang/rust/Makefile head/lang/rust/pkg-plist
Comment on attachment 171856 [details] add DOCS and SRCS options DOCS OPTION is now included. SRCS will be handled in different PR.
Handling of SRCS installation will be handled in a different PR. Closing this one for now.