Bug 210666 - include bsd.default-versions.mk in bsd.port.mk and remove all other inclusions.
Summary: include bsd.default-versions.mk in bsd.port.mk and remove all other inclusions.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL: https://reviews.freebsd.org/D6933
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-28 15:45 UTC by Mathieu Arnold
Modified: 2016-08-03 12:21 UTC (History)
1 user (show)

See Also:
mat: exp-run?


Attachments
patch (6.67 KB, patch)
2016-06-28 15:45 UTC, Mathieu Arnold
no flags Details | Diff
patch-v2 (8.28 KB, patch)
2016-07-21 22:35 UTC, Mathieu Arnold
no flags Details | Diff
patch-v3 (6.71 KB, patch)
2016-07-27 14:21 UTC, Mathieu Arnold
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer 2016-06-28 15:45:34 UTC
Created attachment 171914 [details]
patch
Comment 1 Antoine Brodin freebsd_committer 2016-07-21 20:07:36 UTC
On 10.1 amd64, there are 3 new failures and around 90 new ports skipped

New failures:

+ {"origin"=>"devel/efl", "pkgname"=>"efl-1.16.1_1", "phase"=>"configure", "errortype"=>"configure_error"}
+ {"origin"=>"www/node", "pkgname"=>"node-6.3.0", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"www/node4", "pkgname"=>"node4-4.4.7_4", "phase"=>"build", "errortype"=>"clang"}

Failure logs:

http://package22.nyi.freebsd.org/data/101amd64-default-PR210666/2016-07-21_19h21m54s/logs/errors/efl-1.16.1_1.log
http://package22.nyi.freebsd.org/data/101amd64-default-PR210666/2016-07-21_19h21m54s/logs/errors/node-6.3.0.log
http://package22.nyi.freebsd.org/data/101amd64-default-PR210666/2016-07-21_19h21m54s/logs/errors/node4-4.4.7_4.log
Comment 2 Mathieu Arnold freebsd_committer 2016-07-21 22:34:06 UTC
Mmmm, I see, you can't set WITH_OPENSSL_PORT after bsd.port.options.mk is included, which is a somewhat good thing.
Comment 3 Mathieu Arnold freebsd_committer 2016-07-21 22:35:45 UTC
Created attachment 172815 [details]
patch-v2
Comment 4 Antoine Brodin freebsd_committer 2016-07-23 17:03:08 UTC
New failures on 9.3:

+ {"origin"=>"databases/mysql57-client", "pkgname"=>"mysql57-client-5.7.13_1", "phase"=>"configure", "errortype"=>"???"}
+ {"origin"=>"databases/pgbouncer", "pkgname"=>"pgbouncer-1.7.2", "phase"=>"configure", "errortype"=>"configure_error"}
+ {"origin"=>"deskutils/owncloudclient", "pkgname"=>"owncloudclient-2.2.2", "phase"=>"configure", "errortype"=>"???"}
+ {"origin"=>"editors/pico-alpine", "pkgname"=>"pico-alpine-2.20_1", "phase"=>"configure", "errortype"=>"configure_error"}
+ {"origin"=>"ftp/lftp", "pkgname"=>"lftp-4.7.2", "phase"=>"build", "errortype"=>"gcc4_error"}
+ {"origin"=>"mail/dovecot2", "pkgname"=>"dovecot2-2.2.25_3", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"net-im/jabberd", "pkgname"=>"jabberd-2.3.6", "phase"=>"configure", "errortype"=>"configure_error"}
+ {"origin"=>"net-mgmt/ccnet", "pkgname"=>"ccnet-5.1.3", "phase"=>"build", "errortype"=>"linker_error"}
+ {"origin"=>"net-mgmt/nsca-ng", "pkgname"=>"nsca-ng-1.4", "phase"=>"configure", "errortype"=>"configure_error"}
+ {"origin"=>"net-mgmt/nsca-ng-client", "pkgname"=>"nsca-ng-client-1.4", "phase"=>"configure", "errortype"=>"configure_error"}
+ {"origin"=>"net/glusterfs", "pkgname"=>"glusterfs-3.7.6", "phase"=>"build", "errortype"=>"compiler_error"}
+ {"origin"=>"net/libsrtp", "pkgname"=>"libsrtp-1.5.4", "phase"=>"configure", "errortype"=>"configure_error"}
+ {"origin"=>"security/R-cran-openssl", "pkgname"=>"R-cran-openssl-0.9.4", "phase"=>"stage", "errortype"=>"???"}
+ {"origin"=>"security/gstreamer1-plugins-dtls", "pkgname"=>"gstreamer1-plugins-dtls-1.8.0", "phase"=>"build", "errortype"=>"clang"}
+ {"origin"=>"security/pam_ocra", "pkgname"=>"pam_ocra-1.2", "phase"=>"build", "errortype"=>"???"}
+ {"origin"=>"security/s2n", "pkgname"=>"s2n-20160628", "phase"=>"build", "errortype"=>"compiler_error"}
+ {"origin"=>"security/tor", "pkgname"=>"tor-0.2.7.6_1", "phase"=>"configure", "errortype"=>"configure_error"}
+ {"origin"=>"security/tor-devel", "pkgname"=>"tor-devel-0.2.8.5.r", "phase"=>"configure", "errortype"=>"configure_error"}
+ {"origin"=>"www/aws", "pkgname"=>"aws-17.0.0", "phase"=>"build", "errortype"=>"linker_error"}

Failure logs:

http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/mysql57-client-5.7.13_1.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/pgbouncer-1.7.2.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/owncloudclient-2.2.2.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/pico-alpine-2.20_1.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/lftp-4.7.2.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/dovecot2-2.2.25_3.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/jabberd-2.3.6.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/ccnet-5.1.3.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/nsca-ng-1.4.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/nsca-ng-client-1.4.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/glusterfs-3.7.6.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/libsrtp-1.5.4.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/R-cran-openssl-0.9.4.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/gstreamer1-plugins-dtls-1.8.0.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/pam_ocra-1.2.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/s2n-20160628.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/tor-0.2.7.6_1.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/tor-devel-0.2.8.5.r.log
http://package22.nyi.freebsd.org/data/93i386-default-PR210666/2016-07-23_13h07m31s/logs/errors/aws-17.0.0.log
Comment 5 Mathieu Arnold freebsd_committer 2016-07-27 14:21:23 UTC
Created attachment 173041 [details]
patch-v3

Let's fix everything at once.
Comment 6 Antoine Brodin freebsd_committer 2016-07-30 08:09:51 UTC
Exp-run looks fine.
Comment 7 commit-hook freebsd_committer 2016-08-03 12:10:38 UTC
A commit references this bug:

Author: mat
Date: Wed Aug  3 12:09:39 UTC 2016
New revision: 419511
URL: https://svnweb.freebsd.org/changeset/ports/419511

Log:
  Always include bsd.default-versions.mk in bsd.port.mk.

  The variable defined in it are now always available after including
  bsd.port.pre.mk.

  PR:		210666
  Submitted by:	mat
  Exp-run by:	antoine
  Sponsored by:	Absolight
  Differential Revision:	https://reviews.freebsd.org/D6933

Changes:
  head/Mk/Uses/bdb.mk
  head/Mk/Uses/firebird.mk
  head/Mk/Uses/fortran.mk
  head/Mk/Uses/ghostscript.mk
  head/Mk/Uses/lua.mk
  head/Mk/Uses/mysql.mk
  head/Mk/Uses/perl5.mk
  head/Mk/Uses/pgsql.mk
  head/Mk/Uses/php.mk
  head/Mk/Uses/python.mk
  head/Mk/Uses/ssl.mk
  head/Mk/Uses/tcl.mk
  head/Mk/bsd.apache.mk
  head/Mk/bsd.fpc.mk
  head/Mk/bsd.gcc.mk
  head/Mk/bsd.port.mk
  head/Mk/bsd.ruby.mk