Bug 210716 - sysutils/munin-common: ntp_states plugin TYPO
Summary: sysutils/munin-common: ntp_states plugin TYPO
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-30 05:07 UTC by takefu
Modified: 2016-07-19 14:02 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mat)


Attachments
munin-common.patch (779 bytes, patch)
2016-06-30 05:07 UTC, takefu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2016-06-30 05:07:37 UTC
Created attachment 171965 [details]
munin-common.patch

When the server of the 'condition' is 'outlier' there, a warning is generated in the log.

%> [WARNING] Service ntp_states on fs03.local./[2001:db8::3:123]:4949 returned no data for label peer_ntp2_v6_mfeed_ad_jp
%> [WARNING] Service ntp_states on fs03.local./[2001:db8::3:123]:4949 returned no data for label peer_ntp3_v6_mfeed_ad_jp

# munin-run ntp_states.orig
peer_ntp_bit_drive_ne_jp.value 6
peer_ntp1_v6_mfeed_ad_jp.value 5
Use of uninitialized value $peers_condition{"2001:3a0:0:2005::57:123"} in print at /usr/local/etc/munin/plugins/ntp_states.orig line 161.
peer_ntp2_v6_mfeed_ad_jp.value
Use of uninitialized value $peers_condition{"2001:3a0:0:2006::87:123"} in print at /usr/local/etc/munin/plugins/ntp_states.orig line 161.
peer_ntp3_v6_mfeed_ad_jp.value
peer_127_127_1_0.value 0
Comment 1 Mathieu Arnold freebsd_committer 2016-07-19 13:59:43 UTC
Has this been reported upstream ? If not, please report it upstream.
Comment 2 commit-hook freebsd_committer 2016-07-19 14:02:21 UTC
A commit references this bug:

Author: mat
Date: Tue Jul 19 14:01:24 UTC 2016
New revision: 418792
URL: https://svnweb.freebsd.org/changeset/ports/418792

Log:
  Fix ntp_states in certain cases.

  PR:		210716
  Submitted by:	takefu
  Sponsored by:	Absolight

Changes:
  head/sysutils/munin-common/files/patch-plugins_node.d_ntp__states.in
  head/sysutils/munin-node/Makefile