Bug 210722 - [PATCH] bsdinstall: partedit allows user to modify bootable partition type to non-supported type without warning
Summary: [PATCH] bsdinstall: partedit allows user to modify bootable partition type to...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-sysinstall (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-06-30 12:07 UTC by Dominik Ermel
Modified: 2016-09-20 13:43 UTC (History)
1 user (show)

See Also:


Attachments
Patch with source code of the change (933 bytes, patch)
2016-06-30 12:07 UTC, Dominik Ermel
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Ermel 2016-06-30 12:07:42 UTC
Created attachment 171972 [details]
Patch with source code of the change

Right now is possible to modify bootable partition type to non-bootable type without getting warning from partedit.
Example: if you auto parition drive for arm64, you will get freebsd-ufs as bootable partition; now you are able to change bootable partition type to freebsd-zfs; there will be no warning and the system will install but will not be bootable afterwards.

After this fix, partedit will issue the same warning it does when user attempts to create bootable partition of not supported type, notyfing a user about incoming problem and allowing to think the decision over before commiting the schema.

This has been tested on amd64 and arm64.

Reviewed here:
https://reviews.freebsd.org/D6879
Comment 1 Dominik Ermel 2016-09-20 13:43:58 UTC
Revision integrating this patch:

https://svnweb.freebsd.org/base?view=revision&revision=305415

Author: 	wma
Date: 	Mon Sep 5 08:42:36 2016 UTC (2 weeks, 1 day ago)
Changed paths: 	1

Obtained from:         Semihalf
Submitted by:          Dominik Ermel <der@semihalf.com>
Sponsored by:          Cavium
Reviewed by:           nwhitehorn
Differential Revision: https://reviews.freebsd.org/D6879