Bug 210746 - devel/p5-Sys-SigAction : update TEST dependencies
Summary: devel/p5-Sys-SigAction : update TEST dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rene Ladan
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2016-07-01 17:45 UTC by Rene Ladan
Modified: 2016-07-03 10:56 UTC (History)
1 user (show)

See Also:
svysh.fbsd: maintainer-feedback+

Attachments
patch to update TEST dependencies (431 bytes, patch)
2016-07-01 17:45 UTC, Rene Ladan 		no flags Details | Diff
output of 'make test' (2.84 KB, text/plain)
2016-07-01 17:46 UTC, Rene Ladan 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Ladan freebsd_committer freebsd_triage 2016-07-01 17:45:24 UTC 
Created attachment 172014 [details]
patch to update TEST dependencies

Update the TEST dependencies of this port to exclude the expired devel/p5-Test2. The functionality of that port is now provided by devel/p5-Test-Simple

No PORTREVISION bump because the package does not change.
Comment 1 Rene Ladan freebsd_committer freebsd_triage 2016-07-01 17:46:31 UTC 
Created attachment 172015 [details]
output of 'make test'

in script(1) format
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2016-07-02 09:08:43 UTC 
Just to verify, does this mean you noticed the PR or that you approve it?

A "maintainer approved" flag would be nice to have I think.
Comment 3 Sergei Vyshenski 2016-07-02 10:31:53 UTC 
"maintainer-approval" flag with the patch does not work for me, sorry. 
Yes, I approve it. Thank you very much.
Comment 4 Sergei Vyshenski 2016-07-02 10:35:05 UTC 
Let me guess, that "maintainer-approval" flag should be set by Requestee to "?", and only then the maintainer would be able to set it to "+".
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-07-02 10:45:10 UTC 
A commit references this bug:

Author: rene
Date: Sat Jul  2 10:44:42 UTC 2016
New revision: 417923
URL: https://svnweb.freebsd.org/changeset/ports/417923

Log:
  devel/p5-Sys-SigAction: update TEST dependencies, devel/p5-Test2 is not needed
  any longer.

  PR:		210746
  Submitted by:	myself
  Approved by:	maintainer (Sergei Vyshenski)

Changes:
  head/devel/p5-Sys-SigAction/Makefile
Comment 6 Rene Ladan freebsd_committer freebsd_triage 2016-07-03 10:56:26 UTC 
That's what I meant, there does not seem to be a "maintainer approval" flag.

Perhaps it should be filed as a meta-bug (if not already).