Bug 210959 - editors/p5-Padre: Unbreak build
Summary: editors/p5-Padre: Unbreak build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-10 10:35 UTC by Kurt Jaeger
Modified: 2016-07-31 13:47 UTC (History)
3 users (show)

See Also:
pi: maintainer-feedback+
pi: merge-quarterly+

Attachments
patch (3.32 KB, patch)
2016-07-10 10:35 UTC, Kurt Jaeger 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2016-07-10 10:35:47 UTC 
Created attachment 172308 [details]
patch

- unbreak build by adding include cmath to some file
- make other patches makepatch-compliant
- remove WX_UNICODE=yes (obsolete)
- un-silence several commands during build
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2016-07-10 10:36:17 UTC 
testbuilds@work
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-10 14:26:16 UTC 
I'm sure you have tested, but please confirm this change passes QA 

I also think these changes all qualify under blanket.
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2016-07-10 14:31:41 UTC 
testbuilds are still running. Or do you suggest I should do some run-testing, as well ? The patch is a very minor one (add include cmath).
Comment 4 Mark Felder freebsd_committer freebsd_triage 2016-07-13 13:56:44 UTC 
yes, the MFH is approved under blanket if you're unbreaking it.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-07-31 13:43:34 UTC 
A commit references this bug:

Author: pi
Date: Sun Jul 31 13:42:54 UTC 2016
New revision: 419375
URL: https://svnweb.freebsd.org/changeset/ports/419375

Log:
  editors/p5-Padre: Unbreak build by adding #include <cmath>

  - unbreak build by adding include cmath to
    wx-scintilla/src/scintilla/src/Editor.cxx
  - make other patches makepatch-compliant
  - remove WX_UNICODE=yes (obsolete)
  - un-silence several commands during build

  PR:		210959
  MFH:		2016Q3
  Reported by:	pkg-fallout

Changes:
  head/editors/p5-Padre/Makefile
  head/editors/p5-Padre/files/extra-patch-editor
  head/editors/p5-Padre/files/patch-Makefile.PL
  head/editors/p5-Padre/files/patch-lib_Padre_Wx.pm
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-07-31 13:46:36 UTC 
A commit references this bug:

Author: pi
Date: Sun Jul 31 13:46:03 UTC 2016
New revision: 419376
URL: https://svnweb.freebsd.org/changeset/ports/419376

Log:
  editors/p5-Padre: Unbreak build by adding #include <cmath>

  - unbreak build by adding include cmath to
    wx-scintilla/src/scintilla/src/Editor.cxx
  - make other patches makepatch-compliant
  - remove WX_UNICODE=yes (obsolete)
  - un-silence several commands during build

  PR:		210959
  MFH:		r419375
  Reported by:	pkg-fallout
  Approved by:	ports-secteam (blanket approval)

Changes:
_U  branches/2016Q3/
  branches/2016Q3/editors/p5-Padre/Makefile
  branches/2016Q3/editors/p5-Padre/files/extra-patch-editor
  branches/2016Q3/editors/p5-Padre/files/patch-Makefile.PL
  branches/2016Q3/editors/p5-Padre/files/patch-lib_Padre_Wx.pm
Comment 7 Kurt Jaeger freebsd_committer freebsd_triage 2016-07-31 13:47:07 UTC 
Committed.