Bug 210968 - graphics/qiviewer: Add patch to tolerate file:// in command line arg
Summary: graphics/qiviewer: Add patch to tolerate file:// in command line arg
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Veniamin Gvozdikov
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2016-07-10 13:26 UTC by Jason W. Bacon
Modified: 2016-08-23 06:59 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (vg)

Attachments
Unified diff (871 bytes, text/plain)
2016-07-10 13:26 UTC, Jason W. Bacon 		no flags Details
Unified diff (823 bytes, patch)
2016-07-10 16:38 UTC, Jason W. Bacon 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason W. Bacon freebsd_committer freebsd_triage 2016-07-10 13:26:38 UTC 
Created attachment 172314 [details]
Unified diff

Add patch to tolerate file:// in command line arg.

This prefix is added by Lumina desktop's file browser and possible other tools that exec qiviewer.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-10 14:15:46 UTC 
Thanks Jason, can you confirm this change passes QA (portlint, poudriere) please
Comment 2 Jason W. Bacon freebsd_committer freebsd_triage 2016-07-10 16:38:14 UTC 
Created attachment 172329 [details]
Unified diff

Updated with make makepatch.
Comment 3 Jason W. Bacon freebsd_committer freebsd_triage 2016-07-10 16:40:30 UTC 
Ooops, pardon my slop:

portlint: OK (minor warnings)
testport: OK (poudriere: {9.3,10.1}, {i386,amd64})
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-08-23 06:57:30 UTC 
A commit references this bug:

Author: vg
Date: Tue Aug 23 06:57:24 UTC 2016
New revision: 420650
URL: https://svnweb.freebsd.org/changeset/ports/420650

Log:
  - Add patch to tolerate file:// in command line arg.

  PR:		ports/210968
  Submitted by:	Jason Bacon <bacon4000@gmail.com>

Changes:
  head/graphics/qiviewer/Makefile
  head/graphics/qiviewer/files/
  head/graphics/qiviewer/files/patch-main.cpp
Comment 5 Veniamin Gvozdikov freebsd_committer freebsd_triage 2016-08-23 06:59:07 UTC 
Committed, thank you!