Bug 211150 - devel/sope2: fix LIB_DEPENDS missing iconv dependency in 2.3.13
Summary: devel/sope2: fix LIB_DEPENDS missing iconv dependency in 2.3.13
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-16 03:28 UTC by Euan Thoms
Modified: 2016-07-29 18:51 UTC (History)
3 users (show)

See Also:
koobs: merge-quarterly?

Attachments
Diff patch between current port version and fix taking us to 2.3.13_1 (879 bytes, patch)
2016-07-16 03:28 UTC, Euan Thoms 		euan: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Euan Thoms 2016-07-16 03:28:20 UTC 
Created attachment 172573 [details]
Diff patch between current port version and fix taking us to 2.3.13_1

Simply added the necessary line to LIB_DEPENDS.

portlint -AC       : PASS
make check-plist   : PASS
DEVELOPER=yes make : PASS
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-07-19 14:00:18 UTC 
A commit references this bug:

Author: acm
Date: Tue Jul 19 14:00:02 UTC 2016
New revision: 418790
URL: https://svnweb.freebsd.org/changeset/ports/418790

Log:
  - Add missing dependency
  - Bump PORTREVISION

  PR:		211150
  Submitted by:	Euan Thoms (maintainer)

Changes:
  head/devel/sope2/Makefile
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-07-19 14:01:19 UTC 
A commit references this bug:

Author: acm
Date: Tue Jul 19 14:01:14 UTC 2016
New revision: 418791
URL: https://svnweb.freebsd.org/changeset/ports/418791

Log:
  - Bump PORTREVISION

  PR:		211150
  Submitted by:	Euan Thoms (maintainer)

Changes:
  head/www/sogo2/Makefile
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-20 08:15:52 UTC 
Re-open for MFH
Comment 4 Euan Thoms 2016-07-20 21:09:23 UTC 
(In reply to Kubilay Kocak from comment #3)

Excuse my ignorance, I'm still new to ports development. What does MFH mean? Is there a problem with my patch?
Comment 5 Mark Felder freebsd_committer freebsd_triage 2016-07-26 16:33:27 UTC 
No problems with your patch, we just need to merge this fix to the 2016Q3 branch of the ports tree. This is the default branch that users get when they install FreeBSD 10+, so your fixes won't be available to users unless they updated their /etc/pkg/FreeBSD.conf to point to /latest instead of /quarterly.

The idea is that we have a bit more "stable" branch of the ports tree, sort of like Debian/RedHat does except users get a bunch of updates every 3 months.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-07-26 16:35:41 UTC 
A commit references this bug:

Author: feld
Date: Tue Jul 26 16:34:43 UTC 2016
New revision: 419126
URL: https://svnweb.freebsd.org/changeset/ports/419126

Log:
  MFH: r418791

  - Bump PORTREVISION

  PR:		211150
  Submitted by:	Euan Thoms (maintainer)

  Approved by:	ports-secteam (with hat)

Changes:
_U  branches/2016Q3/
  branches/2016Q3/www/sogo2/Makefile
Comment 7 Euan Thoms 2016-07-28 08:42:18 UTC 
(In reply to Mark Felder from comment #5)

OK,thanks, I undestand now. I figured out that MFH means merge from head.

It loks like the commit is already done. Can we close this bug? If not, is there anything else I can help with?
Comment 8 Mark Felder freebsd_committer freebsd_triage 2016-07-29 18:51:17 UTC 
No, we can close. Thanks!