Bug 211165 - databases/cppdb: plist generation incomplete for non-default OPTIONS
Summary: databases/cppdb: plist generation incomplete for non-default OPTIONS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-17 06:57 UTC by Thomas Zander
Modified: 2016-07-17 11:38 UTC (History)
1 user (show)

See Also:
riggs: maintainer-feedback+


Attachments
fix for databases/cppdb when building modules internally (1.56 KB, patch)
2016-07-17 09:58 UTC, Mohammad S. Babaei
info: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Zander freebsd_committer 2016-07-17 06:57:38 UTC
When building with non-default OPTIONS, e.g.

====> SQLite 3 Backend: you have to select exactly one of them
     SQLITE3_DISABLE=off: Disable SQLite 3 backend
     SQLITE3_INTERNAL=on: Link SQLite 3 backend into CppDB
     SQLITE3_MODULE=off: Build SQLite 3 backend as a CppDB module
====> PostgreSQL Backend: you have to select exactly one of them
     PGSQL_DISABLE=off: Disable PostgreSQL backend
     PGSQL_INTERNAL=on: Link PostgreSQL backend into CppDB
     PGSQL_MODULE=off: Build PostgreSQL backend as a CppDB module
====> MySQL Backend: you have to select exactly one of them
     MYSQL_DISABLE=off: Disable MySQL backend
     MYSQL_INTERNAL=on: Link MySQL backend into CppDB
     MYSQL_MODULE=off: Build MySQL backend as a CppDB module
====> ODBC Backend: you have to select exactly one of them
     ODBC_DISABLE=off: Disable ODBC backend
     ODBC_INTERNAL=on: Link ODBC backend into CppDB
     ODBC_MODULE=off: Build ODBC backend as a CppDB module

the plist is incorrect. I get these from poudriere:
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/libcppdb_mysql.a
Error: Missing: lib/libcppdb_mysql.so
Error: Missing: lib/libcppdb_mysql.so.0
Error: Missing: lib/libcppdb_mysql.so.0.3.1
Error: Missing: lib/libcppdb_odbc.a
Error: Missing: lib/libcppdb_odbc.so
Error: Missing: lib/libcppdb_odbc.so.0
Error: Missing: lib/libcppdb_odbc.so.0.3.1
Error: Missing: lib/libcppdb_postgresql.a
Error: Missing: lib/libcppdb_postgresql.so
Error: Missing: lib/libcppdb_postgresql.so.0
Error: Missing: lib/libcppdb_postgresql.so.0.3.1
Error: Missing: lib/libcppdb_sqlite3.a
Error: Missing: lib/libcppdb_sqlite3.so
Error: Missing: lib/libcppdb_sqlite3.so.0
Error: Missing: lib/libcppdb_sqlite3.so.0.3.1
===> Error: Plist issues found.
Comment 1 Mohammad S. Babaei 2016-07-17 09:58:17 UTC
Created attachment 172603 [details]
fix for databases/cppdb when building modules internally

Thanks! I made a subtle mistake when I created this port. When we build cppdb if we build the drivers internally they'll get embedded into the main module so some of those .so or .a files won't appear in the stage directory.

This patch should fix that build error.
Comment 2 commit-hook freebsd_committer 2016-07-17 11:29:24 UTC
A commit references this bug:

Author: riggs
Date: Sun Jul 17 11:28:47 UTC 2016
New revision: 418664
URL: https://svnweb.freebsd.org/changeset/ports/418664

Log:
  Fix plist for non-default OPTIONs

  While on it: USE_MYSQL -> USES=mysql

  PR:		211165
  Submitted by:	info@babaei.net (maintainer)
  Reported by:	riggs

Changes:
  head/databases/cppdb/Makefile
Comment 3 Thomas Zander freebsd_committer 2016-07-17 11:38:52 UTC
Thanks for the quick fix.

Committed with minor addition: USE_MYSQL -> USES=mysql