Bug 211182 - deskutils/taskwarrior: Add many language OPTIONS
Summary: deskutils/taskwarrior: Add many language OPTIONS
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias Kortkamp
URL:
Keywords: feature, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2016-07-18 00:23 UTC by ribbon
Modified: 2019-01-25 21:21 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (skreuzer)

Attachments
taskwarrior patch for enable language select (1.53 KB, patch)
2016-07-18 00:23 UTC, ribbon 		no flags Details | Diff
update taskwarrior patch for enable language select (Makefile) (1.30 KB, patch)
2016-08-04 20:58 UTC, ribbon 		no flags Details | Diff
distinfo file for taskwarior 2.5.1 (137 bytes, text/plain)
2016-08-04 20:59 UTC, ribbon 		no flags Details
patch for taskwarrior 2.5.1 (258 bytes, patch)
2016-08-04 21:01 UTC, ribbon 		no flags Details | Diff
src_commands_CmdTimesheet.cpp patch for 2.5.1 (258 bytes, patch)
2016-08-04 21:03 UTC, ribbon 		no flags Details | Diff
src_commands_CmdEdit.cpp patch for 2.5.1 (258 bytes, patch)
2016-08-04 21:05 UTC, ribbon 		no flags Details | Diff
src_commands_CmdTimesheet.cpp patch for 2.5.1 (411 bytes, patch)
2016-08-04 21:06 UTC, ribbon 		no flags Details | Diff
patch-src_ISO8601.cpp patch for 2.5.1 (1.08 KB, patch)
2016-08-04 21:06 UTC, ribbon 		no flags Details | Diff
patch-src_ISO8601.h patch for 2.5.1 (681 bytes, patch)
2016-08-04 21:07 UTC, ribbon 		no flags Details | Diff
patch-src_recur.cpp patch for 2.5.1 (595 bytes, patch)
2016-08-04 21:07 UTC, ribbon 		no flags Details | Diff
patch-src_Task.cpp patch for 2.5.1 (391 bytes, patch)
2016-08-04 21:08 UTC, ribbon 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ribbon 2016-07-18 00:23:31 UTC 
Created attachment 172623 [details]
taskwarrior patch for enable language select

taskwarrior patch for enable language select.
tested FreeBSD 9.3 i386 environment.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-18 10:33:29 UTC 
Correctly assign to maintainer

I'm not sure OPTIONS_SINGLE is the most appropriate choice. Are there existing examples of other ports doing this? What about multiple selections (OPTIONS_MULTI), or one OPTION for all languages, or a slave port with SUFFIX -languages? Or slave ports for each -lang in their respective categories?
Comment 2 Steven Kreuzer freebsd_committer freebsd_triage 2016-07-18 22:01:38 UTC 
(In reply to ribbon from comment #0)

This also changes PORTVERSION to 2.5.1 but distinfo needs to be updated and the patches under files/ don't cleanly apply
Comment 3 ribbon 2016-07-21 11:49:49 UTC 
(In reply to Kubilay Kocak from comment #1)

>  What about multiple selections (OPTIONS_MULTI), 
With OPTIONS_MULTI, it can select two or more items.
But, Language that can be selected in the option is only one.
Therefore, I chose OPTIONS_SINGLE.
The choice of language is the same in each language. Therefore, 
I think that there is no need to divide into slave ports.
Comment 4 ribbon 2016-08-04 20:58:35 UTC 
Created attachment 173291 [details]
update taskwarrior patch for enable language select (Makefile)

update Makefile for enable language select
Comment 5 ribbon 2016-08-04 20:59:51 UTC 
Created attachment 173292 [details]
distinfo file for taskwarior 2.5.1

distinfo file for taskwarrior 2.5.1
Comment 6 ribbon 2016-08-04 21:01:37 UTC 
Created attachment 173293 [details]
patch for taskwarrior 2.5.1
Comment 7 ribbon 2016-08-04 21:03:32 UTC 
Created attachment 173294 [details]
src_commands_CmdTimesheet.cpp patch for 2.5.1
Comment 8 ribbon 2016-08-04 21:05:51 UTC 
Created attachment 173295 [details]
src_commands_CmdEdit.cpp patch for 2.5.1
Comment 9 ribbon 2016-08-04 21:06:14 UTC 
Created attachment 173296 [details]
src_commands_CmdTimesheet.cpp patch for 2.5.1
Comment 10 ribbon 2016-08-04 21:06:54 UTC 
Created attachment 173297 [details]
patch-src_ISO8601.cpp patch for 2.5.1
Comment 11 ribbon 2016-08-04 21:07:24 UTC 
Created attachment 173298 [details]
patch-src_ISO8601.h patch for 2.5.1
Comment 12 ribbon 2016-08-04 21:07:59 UTC 
Created attachment 173299 [details]
patch-src_recur.cpp patch for 2.5.1
Comment 13 ribbon 2016-08-04 21:08:38 UTC 
Created attachment 173300 [details]
patch-src_Task.cpp patch for 2.5.1
Comment 14 ribbon 2016-08-04 21:14:18 UTC 
I update patch for taskwarrior 2.5.1.

1) update files/* for 2.5.1
2) update distinfo for 2.5.1
3) update Makefile. 
   in Mk/bsd.options.desc.mk , LANG_xx_DESC is already defined,so I
   delete it in Makefile.
Comment 15 Walter Schwarzenfeld 2018-01-13 21:50:38 UTC 
Maintainer feedback?
Comment 16 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-25 21:21:50 UTC 
The submission is not in patch form (i.e., a unified diff as described in the
Porter's Handbook [1] instead of a raw upload of the port files), so it's hard to
review and do anything with it.  As it stands this is rejected.

[1] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/port-upgrading.html#svn-diff