Bug 211266 - mail/notmuch: Update to 0.22.1
Summary: mail/notmuch: Update to 0.22.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2016-07-21 09:45 UTC by mp39590
Modified: 2016-08-19 13:51 UTC (History)
1 user (show)

See Also:


Attachments
patch (1008 bytes, patch)
2016-07-21 09:45 UTC, mp39590
no flags Details | Diff
patch (3.54 KB, patch)
2016-07-28 12:18 UTC, mp39590
no flags Details | Diff
patch (5.34 KB, patch)
2016-08-09 08:58 UTC, mp39590
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mp39590 2016-07-21 09:45:35 UTC
Created attachment 172777 [details]
patch

- update from 0.22 to 0.22.1
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-07-21 09:47:05 UTC
Thank you for your contribution.

Please:

* Confirm this change passes QA (portlint, poudriere)
* Set maintainer-approval to + on attachments for ports you are maintainer of
Comment 2 Pawel Pekala freebsd_committer freebsd_triage 2016-07-24 16:28:58 UTC
Fails make check-plist:

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: man/man3/notmuch.3.gz
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1
Comment 3 mp39590 2016-07-25 19:10:32 UTC
It works fine for me. Where did you find notmuch.3.gz?

bsd1:/usr/ports/mail/notmuch (master)% make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
Comment 4 Pawel Pekala freebsd_committer freebsd_triage 2016-07-26 15:44:33 UTC
It's seems this port uses devel/doxygen to generate this API manpage, but adding this dependency heavy tool to BUILD_DEPENDS is too much IMHO to get just one manpage.
Comment 5 mp39590 2016-07-28 12:18:16 UTC
Created attachment 173067 [details]
patch

I've added two new options - API_DOCS, which builds man3 api manpage and requires devel/doxygen and MANPAGES, which depends on sphinx.

Thank you for catching this.
Comment 6 mp39590 2016-08-09 08:58:45 UTC
Created attachment 173443 [details]
patch

- update from 0.22 to 0.22.1
- new MANPAGES and DOXYGEN options to control building of documentation (DOXYGEN option is used to build API manpage)
- RUBY option to support ruby bindings
- general port cleanup
Comment 7 Dmitry Marakasov freebsd_committer freebsd_triage 2016-08-18 12:47:28 UTC
===>  Configuring for notmuch-0.22.1
Unrecognized option: --without-api-docs
See:
        ./configure --help

===>  Script "configure" failed unexpectedly.
Comment 8 mp39590 2016-08-18 14:22:32 UTC
(In reply to Dmitry Marakasov from comment #7)
> ===>  Configuring for notmuch-0.22.1
> Unrecognized option: --without-api-docs
> See:
>         ./configure --help
> 
> ===>  Script "configure" failed unexpectedly.

There is new file in the patch - 'files/patch-configure', I forgot to mention it.
Comment 9 Dmitry Marakasov freebsd_committer freebsd_triage 2016-08-18 14:48:55 UTC
Oh, I see now. For some reason it ended up in ports' directory instead of files/
Comment 10 commit-hook freebsd_committer freebsd_triage 2016-08-19 13:51:39 UTC
A commit references this bug:

Author: amdmi3
Date: Fri Aug 19 13:51:11 UTC 2016
New revision: 420468
URL: https://svnweb.freebsd.org/changeset/ports/420468

Log:
  - Update from 0.22 to 0.22.1
  - New MANPAGES and DOXYGEN options to control building of documentation (DOXYGEN option is used to build API manpage)
  - RUBY option to support ruby bindings
  - General port cleanup
  - While here, add LICENSE_FILE

  PR:		211266
  Submitted by:	mp39590@gmail.com (maintainer)

Changes:
  head/mail/notmuch/Makefile
  head/mail/notmuch/distinfo
  head/mail/notmuch/pkg-plist