Bug 211332 - sysutils/u-boot-sinovoip-bpi-m3: style fixes
Summary: sysutils/u-boot-sinovoip-bpi-m3: style fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jared McNeill
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-24 10:04 UTC by Pawel Pekala
Modified: 2016-07-24 14:46 UTC (History)
0 users

See Also:
pawel: maintainer-feedback+


Attachments
style fixes (1.00 KB, patch)
2016-07-24 10:04 UTC, Pawel Pekala
no flags Details | Diff
style fixes v2 (1014 bytes, patch)
2016-07-24 11:31 UTC, Pawel Pekala
pawel: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pekala freebsd_committer 2016-07-24 10:04:45 UTC
Created attachment 172923 [details]
style fixes

2 style bugfixes:

- GMAKE -> MAKE_CMD, MAKE_CMD is always set to required make implementation
- CP -> INSTALL_DATA, INSTALL_DATA makes sure files are always installed
  with proper permissions

Similiar to bug #210982
Comment 1 Pawel Pekala freebsd_committer 2016-07-24 11:31:22 UTC
Created attachment 172925 [details]
style fixes v2

Fix hardcoded package description path also.
Comment 2 Jared McNeill freebsd_committer 2016-07-24 12:43:45 UTC
Looks good to me, please go ahead and commit (I don't have access to the ports tree).
Comment 3 commit-hook freebsd_committer 2016-07-24 14:46:11 UTC
A commit references this bug:

Author: pawel
Date: Sun Jul 24 14:45:17 UTC 2016
New revision: 419007
URL: https://svnweb.freebsd.org/changeset/ports/419007

Log:
  - GMAKE -> MAKE_CMD, MAKE_CMD is always set to required make implementation
  - CP -> INSTALL_DATA, INSTALL_DATA makes sure files are always installed
    with proper permissions
  - Fix hardcoded package description path

  PR:		211332
  Submitted by:	myself
  Approved by:	jmcneill (maintainer)

Changes:
  head/sysutils/u-boot-sinovoip-bpi-m3/Makefile