Bug 211597 - textproc/docproj: Add missing gettext-tools dependency
Summary: textproc/docproj: Add missing gettext-tools dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Warren Block
URL:
Keywords: dogfood, easy, patch
Depends on:
Blocks:
 
Reported: 2016-08-05 14:35 UTC by Warren Block
Modified: 2016-08-19 17:58 UTC (History)
3 users (show)

See Also:
wblock: merge-quarterly+

Attachments
add devel/gettext-tools dependency (925 bytes, patch)
2016-08-05 14:35 UTC, Warren Block 		no flags Details | Diff
fix path to gettext-tools, portlint complaints (1.19 KB, patch)
2016-08-12 14:38 UTC, Warren Block 		wblock: maintainer-approval+
koobs: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Warren Block freebsd_committer freebsd_triage 2016-08-05 14:35:25 UTC 
Created attachment 173317 [details]
add devel/gettext-tools dependency

Translators need the devel/gettext-tools port.  I was sure it was in here.

While here, edit COMMENT to remove one portlint warning, leaving this:

WARN: Makefile: no MASTER_SITES found. is it ok?
WARN: Makefile: Consider defining LICENSE.
WARN: Makefile: wrong dependency value for RUN_DEPENDS. RUN_DEPENDS requires 2 or 3 colon-separated tuples.
0 fatal errors and 3 warnings found.

That RUN_DEPENDS warning looks like a false positive in portlint, because I sure can't see what it's complaining about.
Comment 1 Walter Schwarzenfeld freebsd_triage 2016-08-05 16:47:28 UTC 
It is this line, causes the warning:
.if ${PORT_OPTIONS:MCJK}
RUN_DEPENDS+=  ${FONTS_CJK}    <==
.endif
Comment 2 Walter Schwarzenfeld freebsd_triage 2016-08-05 16:57:30 UTC 
This would silence it:
.if ${PORT_OPTIONS:MCJK}
RUN_DEPENDS+=   ${LOCALBASE}/share/fonts/TrueType/gkai00mp.ttf:chinese/arphicttf \
                ${LOCALBASE}/share/fonts/OTF/ipam.otf:japanese/font-ipa \
                ${LOCALBASE}/share/fonts/nanum-ttf/NanumBarunGothic.ttf:korean/nanumfonts-ttf
.endif
Comment 3 Walter Schwarzenfeld freebsd_triage 2016-08-05 17:01:14 UTC 
Or may better:
.if ${PORT_OPTIONS:MCJK}
MCJK_RUN_DEPENDS+=      ${FONTS_CJK}
.endif
Comment 4 Walter Schwarzenfeld freebsd_triage 2016-08-05 17:04:06 UTC 
correct it:
.if ${PORT_OPTIONS:MCJK}
CJK_RUN_DEPENDS+=      ${FONTS_CJK}
.endif
Comment 5 Walter Schwarzenfeld freebsd_triage 2016-08-05 19:59:34 UTC 
Another question:
Is there any reason this port uses links1, instead of links? (links1 had tons of warnings).
It is the only port still using links1.
Comment 6 Warren Block freebsd_committer freebsd_triage 2016-08-06 02:17:51 UTC 
links1 is used to produce text output.  A while back, I compared the output from several text-mode browsers, and there were differences.  However, at this point, I don't recall specifics.

Another text browser could be used, but the doc toolchain would probably require modification because of different text output.
Comment 7 Warren Block freebsd_committer freebsd_triage 2016-08-12 14:38:40 UTC 
Created attachment 173594 [details]
fix path to gettext-tools, portlint complaints
Comment 8 Warren Block freebsd_committer freebsd_triage 2016-08-12 14:54:50 UTC 
Q/A tests: builds, installs, deinstalls, cleans, portlint thinks it's adequate with hints of almond.
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2016-08-12 15:02:44 UTC 
Comment on attachment 173594 [details]
fix path to gettext-tools, portlint complaints

Approved to (ports) commit

Please include this issue ID in the commit log message, along with MFH: 2016Q3, so that the mfh request can be made
Comment 10 commit-hook freebsd_committer freebsd_triage 2016-08-12 15:38:23 UTC 
A commit references this bug:

Author: wblock
Date: Fri Aug 12 15:37:42 UTC 2016
New revision: 420130
URL: https://svnweb.freebsd.org/changeset/ports/420130

Log:
  Add missing gettext-tools dependency.

  PR:		211597
  Approved by:	koobs
  MFH:		2016Q3
  Sponsored by:	iXsystems

Changes:
  head/textproc/docproj/Makefile
Comment 11 Kubilay Kocak freebsd_committer freebsd_triage 2016-08-12 16:08:31 UTC 
Not closed until MFH is committed

When ports-secteam approve (you'll receive an email), you are free to merge (use Tools/scripts/mfh)

Ping if you're unsure/have questions
Comment 12 commit-hook freebsd_committer freebsd_triage 2016-08-19 17:24:03 UTC 
A commit references this bug:

Author: wblock
Date: Fri Aug 19 17:23:34 UTC 2016
New revision: 420480
URL: https://svnweb.freebsd.org/changeset/ports/420480

Log:
  MFH: r420130

  Add missing gettext-tools dependency.

  PR:		211597
  Approved by:	koobs
  Sponsored by:	iXsystems

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2016Q3/
  branches/2016Q3/textproc/docproj/Makefile
Comment 13 Warren Block freebsd_committer freebsd_triage 2016-08-19 17:58:24 UTC 
Thanks to koobs (and the HYPNO-TOAD!).