Bug 211664 - audio/openal-soft: Add option to enable sndio support
Summary: audio/openal-soft: Add option to enable sndio support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: patch
Depends on: 211554
Blocks:
  Show dependency treegraph
 
Reported: 2016-08-08 14:54 UTC by Tobias Kortkamp
Modified: 2016-08-26 18:11 UTC (History)
3 users (show)

See Also:
pi: maintainer-feedback-


Attachments
openal-soft.diff (825 bytes, patch)
2016-08-08 14:54 UTC, Tobias Kortkamp
tobik: maintainer-approval? (mva)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2016-08-08 14:54:10 UTC
Created attachment 173409 [details]
openal-soft.diff

This adds support for building with the sndio audio output (audio/sndio).

Poudriere@FreeBSD 10.3/amd64 and portlint ok.
Comment 1 Kurt Jaeger freebsd_committer 2016-08-26 13:43:18 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer 2016-08-26 13:43:19 UTC
A commit references this bug:

Author: pi
Date: Fri Aug 26 13:43:12 UTC 2016
New revision: 420919
URL: https://svnweb.freebsd.org/changeset/ports/420919

Log:
  audio/openal-soft: Add option to enable sndio support

  - This adds support for building with the sndio audio output (audio/sndio).

  PR:		211664
  Submitted by:	Tobias Kortkamp <t@tobik.me>
  Approved by:	mva (maintainer timeout)

Changes:
  head/audio/openal-soft/Makefile
Comment 3 Matthew Rezny freebsd_committer 2016-08-26 17:31:11 UTC
The commit of this PR must have been from a stale ports tree as it effectively undoes the commit of PR 210353! I expect there should have been a merge conflict.
Comment 4 commit-hook freebsd_committer 2016-08-26 17:36:52 UTC
A commit references this bug:

Author: pi
Date: Fri Aug 26 17:35:58 UTC 2016
New revision: 420937
URL: https://svnweb.freebsd.org/changeset/ports/420937

Log:
  audio/openal-soft: re-apply r420906

  - r420919 overwrote r420906

  PR:		210353, 211664
  Reported by:	matthew@reztek.cz

Changes:
  head/audio/openal-soft/Makefile
Comment 5 Kurt Jaeger freebsd_committer 2016-08-26 17:38:26 UTC
Sorry, this was an unfortunate sequence of events that caused this.

Both PRs changed different parts of the makefile, so the patch had no conflicts.
Comment 6 Matthew Rezny freebsd_committer 2016-08-26 18:11:23 UTC
Thanks for the quick fixup commit.