Created attachment 173521 [details] cad/NASTRAN port as a diff file NASTRAN is the NASA Structural Analysis System, a finite element analysis program (FEA) completed in the early 1970's. It was the first of its kind and opened the door to computer-aided engineering. The old source code has been released in 2001 under a copyleft NASA-specific license. For reference, the Wikipedia keeps some description of this historical package: https://en.wikipedia.org/wiki/Nastran The port passes portlint and "make check-plist" and only depends on a fortran compiler.
Created attachment 173533 [details] cad/NASTRAN port (svn diff) On second thought; according to hier(7) libexec seems more appropriate for $NASTHOME. In any case end users will probably not notice.
Comment on attachment 173533 [details] cad/NASTRAN port (svn diff) Also available on: https://people.freebsd.org/~pfg/ports/NASTRAN.tgz
In the absence of a poudriere QA test (highly preferred), the following can be used: make stage && make check-plist && make stage-qa && make package Also, can you please update the patch to include the relevant category/Makefile changes too. Other than that, if you're satisfied with QA, and pending the change above, I can (ports) approve the commit
Created attachment 173551 [details] cad/NASTRAN port with cad/Makefile addition I had to use INSTALL_TARGET=install-strip to satisfy stage-qa.
Created attachment 173552 [details] stage log
Good stuff. If/when you're happy, go ahead with commit
Comment on attachment 173551 [details] cad/NASTRAN port with cad/Makefile addition Ports approval
Created attachment 173553 [details] check-plist log
Created attachment 173554 [details] stage-qa log
Created attachment 173555 [details] package log
(In reply to Kubilay Kocak from comment #7) Can't commit: Sending cad/Makefile Adding cad/NASTRAN Adding cad/NASTRAN/Makefile Adding cad/NASTRAN/distinfo Adding cad/NASTRAN/files Adding cad/NASTRAN/files/NASTRAN95-license.txt Adding cad/NASTRAN/files/patch-bin_nastran Adding cad/NASTRAN/files/patch-sb_Makefile Adding cad/NASTRAN/files/patch-um_Makefile Adding cad/NASTRAN/pkg-descr Adding cad/NASTRAN/pkg-plist Transmitting file data .........done Committing transaction... svn: E165001: Commit failed (details follow): svn: E165001: Commit blocked by pre-commit hook (exit code 1) with output: Path "head/cad/NASTRAN/files/NASTRAN95-license.txt" should have svn:keywords set to FreeBSD=%H .... I had to convert the license from .doc to text so it would be readable by the package user. I think it should be remain untouched and not carry a $FreeBSD$ identifier. How is this fixed in subversion?
A commit references this bug: Author: pfg Date: Thu Aug 11 16:22:56 UTC 2016 New revision: 420085 URL: https://svnweb.freebsd.org/changeset/ports/420085 Log: New port: cad/NASTRAN - NASA's classic FEA program. NASTRAN is the NASA Structural Analysis System, a finite element analysis program (FEA) completed in the early 1970's. It was the first of its kind and opened the door to computer-aided engineering. For reference, the Wikipedia keeps some description of this historical package: https://en.wikipedia.org/wiki/Nastran PR: 211739 Approved by: koobs Changes: head/cad/Makefile head/cad/NASTRAN/ head/cad/NASTRAN/Makefile head/cad/NASTRAN/distinfo head/cad/NASTRAN/files/ head/cad/NASTRAN/files/NASTRAN95-license.txt head/cad/NASTRAN/files/patch-bin_nastran head/cad/NASTRAN/files/patch-sb_Makefile head/cad/NASTRAN/files/patch-um_Makefile head/cad/NASTRAN/pkg-descr head/cad/NASTRAN/pkg-plist
(In reply to Pedro F. Giffuni from comment #11) Nevermind ... I figured it out :) svn propset fbsd:nokeywords yes cad/NASTRAN/files/NASTRAN95-license.txt
@Pedro Are you using /usr/ports/Tools/scripts/psvn ? It handles all the properties stuff for you. Same arguments as svn /usr/ports/Tools/scripts/psvn commit ...
Re-close, mid-air collision *shakes fist*
(In reply to Kubilay Kocak from comment #14) No, I used the regular svn. Good to know about psvn. Thanks!
My pleasure :) Re-opening for the change to cad/Makefile (to match PORTNAME). I should have reviewed that first. Please reference this issue in the subsequent commit as well.
@Pedro, It may make more sense and be easier to rename the port (minus "-95"), than to svn mv the svn directory, as the latter will require a MOVED entry among other things: https://www.freebsd.org/doc/en/books/porters-handbook/moved-and-updating-files.html Thoughts?
A commit references this bug: Author: pfg Date: Thu Aug 11 16:39:30 UTC 2016 New revision: 420088 URL: https://svnweb.freebsd.org/changeset/ports/420088 Log: New port: cad/NASTRAN - NASA's classic FEA program. It's called NASTRAN-95, otherwise we cannot grab it from github "nicely". PR: 211739 Approved by: koobs Changes: head/cad/Makefile head/cad/NASTRAN/ head/cad/NASTRAN-95/
(In reply to Kubilay Kocak from comment #18) Ugh.. I missed this comment while making the move. Sorry I am just not used to the ports way of doing things. Renaming the ports requires playing with the github naming and complicates the Makefile. Since it all happened so fast perhaps the move was safe enough?
A commit references this bug: Author: koobs Date: Thu Aug 11 17:00:42 UTC 2016 New revision: 420091 URL: https://svnweb.freebsd.org/changeset/ports/420091 Log: MOVED: Add entry for NASTRAN -> NASTRAN-95 rename Chase the rename of NASTRAN to NASTRAN-95 in r211739 PR: 211739 On behalf of: pfg (src) Changes: head/MOVED
Forgotten to close?