Created attachment 173584 [details] shar archive This is an implementation of Asterisk's answering machine detection (voice activity detection) for FreeSWITCH. WWW: https://github.com/seanbright/mod_amd
Created attachment 173585 [details] shar archive
Hi Šimun, thanks for your contribution Can you please confirm this change passes QA (portlint, poudriere) please. Information on testing can be found here: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html
Created attachment 173588 [details] shar archive
Created attachment 173589 [details] portlint results
Created attachment 173726 [details] portlint results Passed portlint.
Created attachment 173727 [details] shar archive Version that passes QA (portlint and poudriere).
Created attachment 173728 [details] poudriere build log. Passes poudriere.
Thank you Šimun, nice work :) A few (non-obvious) issues remain that high-quality ports don't exhibit. 1) Warning: 'lib/freeswitch/mod/mod_amd.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD} That can be addressed in a post-install: target using ${STRIP_CMD} ${STAGEDIR}/path/to/file.so because the upstream Makefile doesn't have an install-strip target 2) Use at least the -AC flags with portlint (add -N for new ports like this one) for extra checks (some may be false positives, use common sense) 3) Patch out -Werror. This flag shouldn't be included by upstreams in their releases. If it ends up there anyway, it needs to be overriden with -Wno-error, or, removed entirely if a bad Makefile "inadvertently" overrides user-supplied variables/flags, which mod_amd appears to :[ ). 3) Patch the Makefile to remove the @ (silencing command) charin the line containing "@$(CC)". The build currently only produces "--- mod_amd.o ---" output when compiling, and builds should be verbose. I only noticed this because I was looking for -Werror in the compile output and couldn't find it (because the build wasn't verbose)
Created attachment 173729 [details] shar archive Version with all mentioned issues resolved.
Created attachment 173751 [details] portlint results
Created attachment 173753 [details] poudriere build log
@Kubilay Kocak, could you please unassign yourself from this bug so that someone that has time can commit this? Thank you.
Apologies Šimun, I'm not sure how I missed this.
Committed with some minor changes. Sorry that this took so long...
A commit references this bug: Author: tobik Date: Thu Feb 7 09:43:17 UTC 2019 New revision: 492354 URL: https://svnweb.freebsd.org/changeset/ports/492354 Log: New port: net/mod_amd Asterisk app_amd for FreeSWITCH This is an implementation of Asterisk's answering machine detection (voice activity detection) for FreeSWITCH. WWW: https://github.com/seanbright/mod_amd PR: 211773 Submitted by: ?imun Mikecin <numisemis@yahoo.com> Reviewed by: koobs Changes: head/net/Makefile head/net/mod_amd/ head/net/mod_amd/Makefile head/net/mod_amd/distinfo head/net/mod_amd/files/ head/net/mod_amd/files/amd.conf.xml head/net/mod_amd/files/patch-Makefile head/net/mod_amd/pkg-descr