Bug 211799 - graphics/tesseract: Update to 3.04.01, Take MAINTAINER'ship
Summary: graphics/tesseract: Update to 3.04.01, Take MAINTAINER'ship
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2016-08-12 22:41 UTC by Piotr Kubaj
Modified: 2016-08-20 16:31 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (pkubaj)


Attachments
tesseract-3.04.01 (5.55 KB, patch)
2016-08-12 22:41 UTC, Piotr Kubaj
no flags Details | Diff
graphics/tesseract* patch (21.37 KB, patch)
2016-08-13 09:43 UTC, Piotr Kubaj
pkubaj: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2016-08-12 22:41:30 UTC
Created attachment 173615 [details]
tesseract-3.04.01

The attached patch updates the port to 3.04.01 (latest version), switched to Github and sets me as a maintainer.

Also, it adds an option to build training tools.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2016-08-12 22:45:28 UTC
Builds fine on 10.3 :)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2016-08-13 05:04:47 UTC
This should probably be combined with bug 211800 if they need to be committed atomically. 

@Piotr Can you combine the patches there please (if the above is true)
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2016-08-13 09:43:31 UTC
Created attachment 173623 [details]
graphics/tesseract* patch

I'm actually not sure whether it's required, but it certainly wouldn't harm.

Attached is the patch from ${PORTSDIR}/graphics. I've also added NO_ARCH=yes to tesseract-data/Makefile.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-08-16 14:41:53 UTC
A commit references this bug:

Author: pawel
Date: Tue Aug 16 14:41:00 UTC 2016
New revision: 420284
URL: https://svnweb.freebsd.org/changeset/ports/420284

Log:
  - Update graphics/tesseract to version 3.04.01
  - Add TOOLS option for training tools
  - Update graphics/tesseract-data to version 3.04.00
  - Now hosted on GitHub
  - Take maintainership of both ports

  PR:		211799
  Submitted by:	Piotr Kubaj

Changes:
  head/graphics/tesseract/Makefile
  head/graphics/tesseract/distinfo
  head/graphics/tesseract/files/
  head/graphics/tesseract/files/patch-ccstruct_matrix.h
  head/graphics/tesseract/pkg-plist
  head/graphics/tesseract-data/Makefile
  head/graphics/tesseract-data/distinfo
  head/graphics/tesseract-data/pkg-descr
Comment 5 John Marino freebsd_committer freebsd_triage 2016-08-20 16:31:49 UTC
copy of email response:
===
This broke net/tucan.
The new option, TOOLS, is off by default.  Before these tools where built by default and tucan expects the tools to be there.

You might want to set TOOLS back to being built by default.
John