Created attachment 173633 [details] new port shar New port written for freebsd pf with snort. Please review.
Created attachment 173648 [details] fixed a tiny bug but now with new makesum (sorry)
Created attachment 173844 [details] new port v0.2 shar Should be production ready now
Created attachment 173848 [details] new port v0.2 shar
Created attachment 174038 [details] new port v0.3 shar
Created attachment 174046 [details] new port v0.4 shar
Thank you Samee. Please confirm this port passes QA (portlint, poudriere). For more details and instructions see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html
(In reply to Kubilay Kocak from comment #6) Passed portlint as far as I could tell. No errors, make install reinstall deinstall all function correctly and the port successfully registers itself.
Created attachment 174158 [details] port update v0.5 shar
(In reply to Kubilay Kocak from comment #6) Hi Koobs :) When I respond to your comments in bugzilla, do you receive them via email? Just wondering. I think I fixed the qa bug in v0.5 but not sure. Also polished the program a little. And should I be posting updates to this bugzilla page? Thanks. Samee
A commit references this bug: Author: woodsb02 Date: Tue Aug 30 23:37:48 UTC 2016 New revision: 421135 URL: https://svnweb.freebsd.org/changeset/ports/421135 Log: Add new port security/snort2pfcd, which analyzes snort alert output and blocks ip addresses using pf for a specified period of time. PR: 211813 Submitted by: onestsam@gmail.com Reviewed by: adamw, mat (mentors) Approved by: koobs (mentor) Differential Revision: https://reviews.freebsd.org/D7712 Changes: head/security/Makefile head/security/snort2pfcd/ head/security/snort2pfcd/Makefile head/security/snort2pfcd/distinfo head/security/snort2pfcd/files/ head/security/snort2pfcd/files/patch-Makefile head/security/snort2pfcd/files/snort2pfcd.in head/security/snort2pfcd/pkg-descr
Committed - thanks for your work on this Samee. Some possible future improvements you could consider as maintainer: - Get the security/snort2pfcd/files/patch-Makefile patch incorporated in the upstream code. - Get this code submitted this code to a source code repository (e.g. GitHub) - Create a website and add to pkg-descr with WWW: (could link to GitHub page)
A couple of other things Samee: - I created a copy of the snort2pfcd rc script, and put it in the ports tree. This is so that we can patch out the /usr/local using %%LOCALBASE%%. The rc script is probably not something that applies to any other operating systems anyway, so it is better placed in the ports tree than in the upstream code - it can be removed from your upstream code in the future if you like (it is not being used by the port). - I simplified your port a lot, have a look at the committed port Makefile, and compare it to the one you had prepared (using diff) to see for yourself (for future ports). Thanks again for submitting this!
Thank you very, very much Ben! Working on applying all of your changes now.
Created attachment 174239 [details] port update v0.6 shar
(In reply to Samee Shahzada from comment #14) Hi Samee, This bug report is now closed as the port has been committed to the ports tree. Please submit all future changes, and your current proposed change, as a separate bug report. It should have the title "security/snort2pfcd: Update to 0.6" or similar. Also, the .shar format should only be used to propose a new port. Once a port exists in the tree, the preferred format is patches in the unified diff format. This can be generated using diff(1) command "diff -ru" to compare a copy of your port to that which is already in the ports tree, or preferably by making your changes directly into your local copy of the ports tree that was checked out using subversion, as using "svn diff /usr/ports/security/snort2pfcd > ~/snort2pfcd.patch" to generate a patch file in your home directory. Thanks, Ben
PS: you can feel free to CC me on the new bug report when you create it.
Hi Samee, I can see you have uploaded the source to GitHub - that's great! Could you please do me a favour and tag the current commit as release 0.6? It would be nice to populate the README.md file also. https://github.com/onestsam/snort2pfcd I will then update the port for you. Thanks, Ben
(In reply to Ben Woods from comment #17) Thanks Ben, Im still trying to figure out git. I uploaded the files to git but they were symlinks on my computer and as I discovered, git just uploaded the symlinks and did not follow them. Samee