Bug 212091 - ports-mgmt/portlint should warn if distinfo misses TIMESTAMP (svn commit checks reject missing TIMESTAMP)
Summary: ports-mgmt/portlint should warn if distinfo misses TIMESTAMP (svn commit chec...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks: 220087
  Show dependency treegraph
 
Reported: 2016-08-24 04:14 UTC by Kurt Jaeger
Modified: 2017-06-17 22:24 UTC (History)
3 users (show)

See Also:


Attachments
fix issue with timestamp check (570 bytes, patch)
2016-11-10 18:54 UTC, Joseph Mingrone
jrm: maintainer-approval? (marcus)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer 2016-08-24 04:14:10 UTC
svn commits in the ports tree fail if distinfo has no TIMESTAMP field.

portlint should warn if the TIMESTAMP is missing and if the TIMESTAMP
has some value in the future or too far in the past.
Comment 1 commit-hook freebsd_committer 2016-11-09 00:40:04 UTC
A commit references this bug:

Author: marcus
Date: Wed Nov  9 00:39:19 UTC 2016
New revision: 425779
URL: https://svnweb.freebsd.org/changeset/ports/425779

Log:
  Update to 2.17.5.

  * Allow https URLs for the WWW line in pkg-descr.  Why are we only NOW doing
    this? [1]
  * Check TIMESTAMP to make sure it's in the present/past, but not more than 30
    days in the past. [2]

  PR:		212091 [2]
  Submitted by:	amdmi3 [1]
  Differential Revision:	D8462 [1]

Changes:
  head/ports-mgmt/portlint/Makefile
  head/ports-mgmt/portlint/src/portlint.pl
Comment 2 Joe Marcus Clarke freebsd_committer 2016-11-09 00:43:33 UTC
Added to 2.17.5.
Comment 3 Joseph Mingrone freebsd_committer 2016-11-10 18:54:52 UTC
Created attachment 176866 [details]
fix issue with timestamp check

When checking the timestamp, comparisons were being made with 'TIMESTAMP = 1478803026' instead of just '1478803026'.  This resulted in these errors.

% portlint
Argument "TIMESTAMP = 1478803026\n" isn't numeric in numeric gt (>) at /usr/local/bin/portlint line 398, <IN> line 1.
Comment 4 Joe Marcus Clarke freebsd_committer 2016-11-11 02:14:01 UTC
Whoops, didn't revert to $1.  Thanks.
Comment 5 commit-hook freebsd_committer 2016-11-11 02:14:09 UTC
A commit references this bug:

Author: marcus
Date: Fri Nov 11 02:13:40 UTC 2016
New revision: 425858
URL: https://svnweb.freebsd.org/changeset/ports/425858

Log:
  Correct a typo with TIMESTAMP handling.  While here, don't use a pure magic number
  for the 30 days worth of seconds.

  PR:		212091
  Submitted by:	jrm

Changes:
  head/ports-mgmt/portlint/Makefile
  head/ports-mgmt/portlint/src/portlint.pl