Bug 212111 - ng_btsocket(4) lacks info on updated struct sockaddr_l2cap layout
Summary: ng_btsocket(4) lacks info on updated struct sockaddr_l2cap layout
Status: New
Alias: None
Product: Documentation
Classification: Unclassified
Component: Manual Pages (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-24 14:01 UTC by Dmitry Marakasov
Modified: 2018-04-10 19:44 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2016-08-24 14:01:06 UTC
/usr/include/netgraph/bluetooth/include/ng_btsocket.h from 11.0:

struct sockaddr_l2cap {
    u_char      l2cap_len;  /* total length */
    u_char      l2cap_family;   /* address family */
    u_int16_t   l2cap_psm;  /* PSM (Protocol/Service Multiplexor) */
    bdaddr_t    l2cap_bdaddr;   /* address */
    u_int16_t   l2cap_cid;      /*cid*/
    u_int8_t    l2cap_bdaddr_type; /*address type*/
};

Last two fields were added in r281198 by takawata@:

https://svnweb.freebsd.org/base/head/sys/netgraph/bluetooth/include/ng_btsocket.h?r1=180399&r2=281198

with warning telling to check new fields for being initialized.

the same struct description from ng_btsocket(4):

struct sockaddr_l2cap {
    u_char    l2cap_len;    /* total length */
    u_char    l2cap_family; /* address family */
    uint16_t  l2cap_psm;    /* Protocol/Service Multiplexor */
    bdaddr_t  l2cap_bdaddr; /* address */
};

1) The manpage should be updated
2) The new fields should be documented

The latter is crucial for fixing numerous ports which have problems on 11.x (some fail to build because of warning and -Werror, others may fail in runtime because improperly initialized fields)