Bug 212289 - devel/binutils: should provide a test/regression target
Summary: devel/binutils: should provide a test/regression target
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Baptiste Daroussin
Keywords: patch
Depends on:
Reported: 2016-08-31 16:50 UTC by Pedro F. Giffuni
Modified: 2020-04-25 15:55 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (bapt)

Proof-of-concept patch (677 bytes, patch)
2016-08-31 16:50 UTC, Pedro F. Giffuni
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni freebsd_committer 2016-08-31 16:50:06 UTC
Created attachment 174258 [details]
Proof-of-concept patch

Being such a critical third-party module we should have testing options for this port so we can catch regressions or evaluate better before enabling features.

I borrowed the test option from the GCC port. I am not sure this adapts perfectly to binutils as the tests don't finish but it's a start.
Comment 1 Baptiste Daroussin freebsd_committer 2017-10-02 11:34:13 UTC
The approach is wrong, all what is needed is a simple:

Also note that to depend on dejagnu, TEST_DEPENDS=... should be enough.

Btw the testsuite works here to the exception of some weird -Wa,-madd-bnd-prefix which clang does not accept
Comment 2 Gleb Popov freebsd_committer 2020-04-25 13:19:09 UTC
The port does have test target now, although it fails for me with

gcctestdir/ld: internal error in shndx, at ./symtab.h:170
c++: error: linker command failed with exit code 1 (use -v to see invocation)

Anyways, can this be closed?
Comment 3 Pedro F. Giffuni freebsd_committer 2020-04-25 15:55:46 UTC
Done ...