Bug 212349 - [PATCH] editors/texstudio: Use system hunspell and quazip
Summary: [PATCH] editors/texstudio: Use system hunspell and quazip
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks: 211916
  Show dependency treegraph
 
Reported: 2016-09-03 14:48 UTC by Raphael Kubo da Costa
Modified: 2016-09-10 08:17 UTC (History)
1 user (show)

See Also:
rakuco: maintainer-feedback-


Attachments
Proposed patch (1.39 KB, patch)
2016-09-03 14:48 UTC, Raphael Kubo da Costa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer 2016-09-03 14:48:36 UTC
Created attachment 174335 [details]
Proposed patch

The attached patch makes texstudio stop building its own bundled copies of quazip and hunspell.

Using bundled libraries is bad for several reasons, including leaving ports vulnerable to security issues and also for breaking the build, which happens with Qt 5.6 that passes -std=gnu++11 by default when the compiler supports it:

hunspell/affentry.hxx:30:94: error: cannot initialize a parameter of type 'unsigned short' with an rvalue of type 'nullptr_t'
hunspell/affentry.hxx:93:103: error: cannot initialize a parameter of type 'unsigned short' with an rvalue of type 'nullptr_t'

Switching to the system versions fixes everything.
Comment 1 commit-hook freebsd_committer 2016-09-10 08:16:27 UTC
A commit references this bug:

Author: rakuco
Date: Sat Sep 10 08:15:25 UTC 2016
New revision: 421674
URL: https://svnweb.freebsd.org/changeset/ports/421674

Log:
  Use system hunspell and quazip

  Stop building its own bundled copies of quazip and hunspell.

  Using bundled libraries is bad for several reasons [1], including breaking the
  build, which happens with Qt 5.6 that passes -std=gnu++11 by default when the
  compiler supports it:

      hunspell/affentry.hxx:30:94: error: cannot initialize a parameter of type 'unsigned short' with an rvalue of type 'nullptr_t'
      hunspell/affentry.hxx:93:103: error: cannot initialize a parameter of type 'unsigned short' with an rvalue of type 'nullptr_t'

  Switching to the system versions fixes everything.

  [1] https://www.freebsd.org/doc/en/books/porters-handbook/bundled-libs.html

  PR:		212349
  Approved by:	portmgr (mat)

Changes:
  head/editors/texstudio/Makefile