Starting with the upcoming Qt 5.6 port, Qt will automatically pass -std=gnu++11 (or equivalent) when it detects it's supported by the compiler.
RetroShare currently fails to build in C++11 mode, and the attached upstream patches fix the failures. One of them, patch-git_5e94c772, allows some home-grown patches to be removed.
All those changes being backported are part of v0.6.1, released a few days ago.
Created attachment 174361 [details]
Are you aware of PR#210682 ? Does that patch still apply after that PR ?
Bug 210682 is just picking a random git revision to use instead of an official release; it includes some of the changes in files/ done here simply because they are present in the git revision included there. Since I don't use RetroShare myself, I've chosen to just include the necessary patches to allow kde@ to proceed with the Qt 5.6 update.
PR#210682 already has maintainer approval, so if we speed up on that PR, wouldn't that help KDE as well ?
That's true (even though updating to random revisions feels weird to me); I can confirm that the patch in that PR is enough to fix the build with Qt 5.6 too. Will you take care of landing that one given your comment there?
Yes, I'm testbuilding right now. If it works out, I'll commit PR#210682
OK then, thanks!