Bug 212366 - [PATCH] editors/texmaker: Switch to system hunspell
Summary: [PATCH] editors/texmaker: Switch to system hunspell
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords: patch
Depends on:
Blocks: 211916
  Show dependency treegraph
 
Reported: 2016-09-04 08:35 UTC by Raphael Kubo da Costa
Modified: 2016-09-10 08:21 UTC (History)
1 user (show)

See Also:
rakuco: maintainer-feedback-


Attachments
Proposed patch (3.02 KB, patch)
2016-09-04 08:35 UTC, Raphael Kubo da Costa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer 2016-09-04 08:35:03 UTC
Created attachment 174363 [details]
Proposed patch

The attached patch makes texmaker stop building its own, outdated bundled copy of hunspell. In addition to the obvious reasons, this is necessary to get the port to build with the upcoming Qt 5.6, as it passes -std=gnu++11 to the compiler automatically when it's supported and building the bundled hunspell failed like this:

hunspell/affentry.hxx:28:94: error: cannot initialize a parameter of type 'unsigned short' with an rvalue of type 'nullptr_t'
hunspell/affentry.hxx:91:103: error: cannot initialize a parameter of type 'unsigned short' with an rvalue of type 'nullptr_t'
Comment 1 commit-hook freebsd_committer 2016-09-10 08:21:29 UTC
A commit references this bug:

Author: rakuco
Date: Sat Sep 10 08:20:27 UTC 2016
New revision: 421675
URL: https://svnweb.freebsd.org/changeset/ports/421675

Log:
  Use system hunspell

  Stop building texmaker's own, utdated bundled copy of hunspell. In addition to
  the obvious reasons, this is necessary to get the port to build with the
  upcoming Qt 5.6, as it passes -std=gnu++11 to the compiler automatically when
  it's supported and building the bundled hunspell failed like this:

      hunspell/affentry.hxx:28:94: error: cannot initialize a parameter of type 'unsigned short' with an rvalue of type 'nullptr_t'
      hunspell/affentry.hxx:91:103: error: cannot initialize a parameter of type 'unsigned short' with an rvalue of type 'nullptr_t'

  See also: https://www.freebsd.org/doc/en/books/porters-handbook/bundled-libs.html

  PR:		212366
  Approved by:	portmgr (mat)

Changes:
  head/editors/texmaker/Makefile
  head/editors/texmaker/files/patch-texmaker.pro