Bug 212383 - [NEW PORT] x11-fm/sunflower: small two panel file manager written in Python
Summary: [NEW PORT] x11-fm/sunflower: small two panel file manager written in Python
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Duchateau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-05 09:57 UTC by Ivan
Modified: 2016-09-20 11:11 UTC (History)
1 user (show)

See Also:


Attachments
shar (23.27 KB, text/plain)
2016-09-05 09:57 UTC, Ivan
no flags Details
poudriere test (73.16 KB, text/x-log)
2016-09-05 10:04 UTC, Ivan
no flags Details
New shar archive (22.44 KB, text/plain)
2016-09-20 06:34 UTC, Olivier Duchateau
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan 2016-09-05 09:57:35 UTC
Created attachment 174382 [details]
shar

Sunflower is a small two panel file manager written on Python
WWW: http://sunflower-fm.org/

I'm using it on my laptop, so I thought sharing it with other users would be good doing :-)
Comment 1 Ivan 2016-09-05 10:04:07 UTC
Created attachment 174383 [details]
poudriere test
Comment 2 Olivier Duchateau freebsd_committer freebsd_triage 2016-09-20 06:34:53 UTC
Created attachment 174984 [details]
New shar archive

I made some changes:

- Replace PORTVERSION and DISTVERSIONSUFFIX by DISTVERSION [1]
- Use the real MASTER_SITES instead of GitHub host
- Update dependencies (I found dbus, setproctitle modules are used)
- Sort USES
- Remove NLS option because there's no mechanism to avoid load *.mo files. And install only .mo files no .po

Tested successfully with poudriere, if everything you seem good, I commit your port.

[1] https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-distversion
Comment 3 Ivan 2016-09-20 06:56:41 UTC
Thank you for additional work you put into this! May I ask, why shebang fix was removed? I remember shebang was pointed to linux location of python.
Comment 4 Olivier Duchateau freebsd_committer freebsd_triage 2016-09-20 08:44:49 UTC
(In reply to Ivan from comment #3)

Shebang is fine. Usually when we write Python script either we use the real interpreter directive (here /usr/local/bin/python2.7) or looking up the path to python interpreter through "env".

env path is correct:

which env
/usr/bin/env
Comment 5 Ivan 2016-09-20 09:01:37 UTC
Ahh, I see. Please, commit the port.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-09-20 11:09:39 UTC
A commit references this bug:

Author: olivierd
Date: Tue Sep 20 11:09:05 UTC 2016
New revision: 422493
URL: https://svnweb.freebsd.org/changeset/ports/422493

Log:
  Small and highly customizable twin-panel file manager with support for plugins.

  WWW: http://sunflower-fm.org/

  PR:		212383
  Submitted by:	Ivan <bsd@abinet.ru>

Changes:
  head/x11-fm/Makefile
  head/x11-fm/sunflower/
  head/x11-fm/sunflower/Makefile
  head/x11-fm/sunflower/distinfo
  head/x11-fm/sunflower/files/
  head/x11-fm/sunflower/files/patch-Sunflower.py
  head/x11-fm/sunflower/pkg-descr
  head/x11-fm/sunflower/pkg-plist
Comment 7 Olivier Duchateau freebsd_committer freebsd_triage 2016-09-20 11:11:17 UTC
Committed