Bug 212512 - lang/tcl86: remove unnecessary use of fpsetround
Summary: lang/tcl86: remove unnecessary use of fpsetround
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-tcltk mailing list
URL:
Keywords:
Depends on:
Blocks: 201763
  Show dependency treegraph
 
Reported: 2016-09-09 00:32 UTC by Ed Maste
Modified: 2016-09-09 07:48 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (tcltk)


Attachments
add patch file to remove fpsetround use in tcl (1.18 KB, patch)
2016-09-09 00:32 UTC, Ed Maste
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer 2016-09-09 00:32:08 UTC
Created attachment 174566 [details]
add patch file to remove fpsetround use in tcl

fpsetround is non-standard and is not provided on arm64 or riscv. On other architectures where fpsetround does exist, fpsetround(FP_RN) just sets the rounding mode to the already-set default, so it serves no purpose.
Comment 1 Pietro Cerutti freebsd_committer 2016-09-09 07:36:04 UTC
Pushed upstream: http://core.tcl.tk/tcl/info/20c19f9d5593455a
Comment 2 Pietro Cerutti freebsd_committer 2016-09-09 07:47:29 UTC
I took the liberty to fix tcl84, tcl85 and tcl87 too.
Comment 3 commit-hook freebsd_committer 2016-09-09 07:47:30 UTC
A commit references this bug:

Author: gahr
Date: Fri Sep  9 07:47:02 UTC 2016
New revision: 421600
URL: https://svnweb.freebsd.org/changeset/ports/421600

Log:
  lang/tcl8*: remove use of fpsetround

  Pushed upstream: http://core.tcl.tk/tcl/info/20c19f9d5593455a

  PR:		212512
  Submitted by:	emaste

Changes:
  head/lang/tcl84/files/patch-tclUnixInit.c
  head/lang/tcl85/files/patch-tclUnixInit.c
  head/lang/tcl86/files/patch-unix-tclUnixInit.c
  head/lang/tcl87/Makefile
  head/lang/tcl87/distinfo