Bug 212530 - x11-wm/fluxbox-devel: Revive port
Summary: x11-wm/fluxbox-devel: Revive port
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-09-09 18:13 UTC by lightside
Modified: 2018-05-14 13:49 UTC (History)
1 user (show)

See Also:


Attachments
Proposed patch (since 187097 revision) (32.25 KB, patch)
2016-09-09 18:13 UTC, lightside
no flags Details | Diff
Proposed patch (since 187097 revision) (32.25 KB, patch)
2016-09-09 19:06 UTC, lightside
no flags Details | Diff
Proposed patch, based on copied x11-wm/fluxbox port (since 421576 revision) (15.30 KB, patch)
2016-10-25 15:03 UTC, lightside
no flags Details | Diff
Proposed patch, based on copied x11-wm/fluxbox port (since 421576 revision) (15.31 KB, patch)
2016-10-25 15:46 UTC, lightside
no flags Details | Diff
Proposed patch, based on copied x11-wm/fluxbox port (since 432090 revision) (17.19 KB, patch)
2017-03-04 23:30 UTC, lightside
no flags Details | Diff
Patch based on copied x11-wm/fluxbox port (since 432090 revision) (17.29 KB, patch)
2018-05-14 13:48 UTC, lightside
no flags Details | Diff
The archived x11-wm/fluxbox-devel port (2.73 KB, application/x-bzip)
2018-05-14 13:49 UTC, lightside
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2016-09-09 18:13:47 UTC
Created attachment 174587 [details]
Proposed patch (since 187097 revision)

Patch to revive x11-wm/fluxbox-devel port (except infrastructure changes).

The x11-wm/fluxbox-devel port was removed in ports r187729 and merged into x11-wm/fluxbox port with following request:
"Request by:     too many to list (include developers)"

In process of creation of bug 211814, I attached my (personal) version of x11-wm/fluxbox-devel port to show it for current maintainer of x11-wm/fluxbox port or people who may read the PR. The maintainer suggested to create separate PR for it in bug 211814 comment 11.

I didn't change the MAINTAINER section, but it may be changed to ports@, if mezz@ is not active.

The difference between current x11-wm/fluxbox (ports r421576) and x11-wm/fluxbox-devel ports is usage of different (sed) patches and other description for pkg-descr file, based on information from https://en.wikipedia.org/wiki/Fluxbox page. Also I didn't add XINERAMA to OPTIONS_DEFAULT.
Comment 1 lightside 2016-09-09 19:06:35 UTC
Created attachment 174592 [details]
Proposed patch (since 187097 revision)

(In reply to comment #0)
> The difference between current x11-wm/fluxbox (ports r421576)
Fix for Bugzilla parser: ports r421576.

Reverted some punctuation for pkg-descr file, based on original information.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2016-10-25 14:03:39 UTC
Comment on attachment 174592 [details]
Proposed patch (since 187097 revision)

Too many changes in the diff which are only of historic value. Try rebasing after |svn cp x11-wm/fluxbox{,-devel}| or convert to a slave port.

Revived ports are treated as new and won't be accepted unless a maintainer is assigned. If the maintainer isn't the same as submitter approval is required. mezz@ currently doesn't maintain any port and stopped committing since ports r331734.
Comment 3 lightside 2016-10-25 15:03:31 UTC
Created attachment 176146 [details]
Proposed patch, based on copied x11-wm/fluxbox port (since 421576 revision)

(In reply to comment #2)
> Too many changes in the diff which are only of historic value. Try rebasing
> after |svn cp x11-wm/fluxbox{,-devel}| or convert to a slave port.
Ok, I attached new patch, which based on copied x11-wm/fluxbox port (since ports r421576) to x11-wm/fluxbox-devel.

(In reply to comment #1)
> Also I didn't add XINERAMA to OPTIONS_DEFAULT.
The XINERAMA in OPTIONS_DEFAULT was migrated from x11-wm/fluxbox port.

(In reply to comment #2)
> Revived ports are treated as new and won't be accepted unless a maintainer is
> assigned.
This wasn't the case for bug 198025, related to revived textproc/xxdiff and textproc/xxdiff-scripts ports.

(In reply to comment #2)
> If the maintainer isn't the same as submitter approval is required.
> mezz@currently doesn't maintain any port and stopped committing since
> ports r331734.
I understood. I changed MAINTAINER to ports@, as I said in comment #0. My reasoning was explained in bug 211814 comment #18. I created devel version of port as intermediate solution before new Fluxbox release version (or for tests of development version(s)). If there are no other interest about such a port in FreeBSD ports, then this PR may be closed. "The batteries are not included", as someone said.
Comment 4 lightside 2016-10-25 15:46:55 UTC
Created attachment 176147 [details]
Proposed patch, based on copied x11-wm/fluxbox port (since 421576 revision)

Cosmetic fixes.

To note:
The actual patch is shorter, if removing files directory.
Comment 5 lightside 2017-03-04 23:30:44 UTC
Created attachment 180517 [details]
Proposed patch, based on copied x11-wm/fluxbox port (since 432090 revision)

Updated to following commit:
https://github.com/fluxbox/fluxbox/commit/bdfaaa0e173ad63e64c1166c0b524e1639ced12f
with following changes:
https://github.com/fluxbox/fluxbox/compare/50b6102...bdfaaa0

- Added libtool to USES, because AC_CHECK_LIBM defined in ${LOCALBASE}/share/aclocal/libtool.m4
- Added gettext-tools to NLS_USES, because AM_ICONV defined in ${LOCALBASE}/share/aclocal/iconv.m4
Comment 6 Tobias Kortkamp freebsd_committer freebsd_triage 2018-05-14 11:38:35 UTC
(In reply to lightside from comment #3)

> I understood. I changed MAINTAINER to ports@, as I said in comment #0. My reasoning was explained in bug 211814 comment #18. I created devel version of port as intermediate solution before new Fluxbox release version (or for tests of development version(s)). If there are no other interest about such a port in FreeBSD ports, then this PR may be closed. "The batteries are not included", as someone said.

As Jan said in comment #2 this new port needs a maintainer other than ports@,
so I'm going to close this as that's not the case now and you don't want to be
maintainer as you said in bug 211814 comment #18.
Comment 7 lightside 2018-05-14 13:48:37 UTC
Created attachment 193390 [details]
Patch based on copied x11-wm/fluxbox port (since 432090 revision)

(In reply to Tobias Kortkamp from comment #6)
The point of this PR, while it wasn't closed, was an alternative development port before new possible release. As far as I know, there is no new release still. Someone even tried to apply changes from Git repository in ports r469574.

There was a possibility, that someone maybe interested to be a maintainer for this port, of course, but this wasn't a main point of this PR (see comment #3).

Updated to following commit:
https://github.com/fluxbox/fluxbox/commit/248b15c25f924c56da457ed144050e65013335b0
with following changes:
https://github.com/fluxbox/fluxbox/compare/bdfaaa0e173ad63e64c1166c0b524e1639ced12f...248b15c25f924c56da457ed144050e65013335b0
Comment 8 lightside 2018-05-14 13:49:19 UTC
Created attachment 193391 [details]
The archived x11-wm/fluxbox-devel port

Also attached x11-wm/fluxbox-devel port in the archive.