Bug 212701 - devel/ninja: python is needed at run-time + ppoll fix + tests
Summary: devel/ninja: python is needed at run-time + ppoll fix + tests
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Grzegorz Blach
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-09-15 12:31 UTC by Pietro Cerutti
Modified: 2016-09-15 16:27 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gblach)


Attachments
patch (2.17 KB, text/plain)
2016-09-15 12:31 UTC, Pietro Cerutti
no flags Details
patch (2.52 KB, patch)
2016-09-15 12:45 UTC, Pietro Cerutti
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pietro Cerutti freebsd_committer 2016-09-15 12:31:42 UTC
Created attachment 174795 [details]
patch

* Python is required at runtime to launch the webserver needed by the "browse" tool, see [1].

* A patch to configure.py has been added to enable using ppoll(2) on FreeBSD. This has been reported in [2].

* The upstream GitHub account has been changed from martine to ninja-build. Martine was renamed and now redirects to ninja-build. Please note that the checksum of the distfile is the same. 

* Self-tests have been enabled.

[1] https://github.com/ninja-build/ninja/blob/master/doc/manual.asciidoc#extra-tools
[2] https://github.com/ninja-build/ninja/pull/1185
Comment 1 Pietro Cerutti freebsd_committer 2016-09-15 12:45:15 UTC
Created attachment 174796 [details]
patch

patch
Comment 2 commit-hook freebsd_committer 2016-09-15 16:26:58 UTC
A commit references this bug:

Author: gblach
Date: Thu Sep 15 16:26:00 UTC 2016
New revision: 422215
URL: https://svnweb.freebsd.org/changeset/ports/422215

Log:
  - Switch GH_ACCOUNT to ninja-build
  - Use python also at runtime (needed by 'browse' tool)
  - Add do-test section
  - Change WWW to https://ninja-build.org/
  - Bump PORTREVISION

  PR:		212701
  Submitted by:	gahr

Changes:
  head/devel/ninja/Makefile
  head/devel/ninja/distinfo
  head/devel/ninja/pkg-descr
Comment 3 Grzegorz Blach freebsd_committer 2016-09-15 16:27:39 UTC
Committed without ppoll fix. Thanks.