Bug 212828 - net/intel-em-kmod: new port for Intel em driver version 7.6.2
Summary: net/intel-em-kmod: new port for Intel em driver version 7.6.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-19 16:12 UTC by Franco Fichtner
Modified: 2016-10-07 19:40 UTC (History)
4 users (show)

See Also:


Attachments
adds net/intel-em-kmod.diff (2.94 KB, patch)
2016-09-19 16:12 UTC, Franco Fichtner
no flags Details | Diff
poudriere testport build log (25.51 KB, text/plain)
2016-09-19 16:19 UTC, Franco Fichtner
no flags Details
revised patch (2.81 KB, patch)
2016-09-29 04:29 UTC, Franco Fichtner
no flags Details | Diff
slave port example (2.08 KB, patch)
2016-09-29 21:59 UTC, Serhii (Sergey) Kozlov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Franco Fichtner 2016-09-19 16:12:54 UTC
Created attachment 174968 [details]
adds net/intel-em-kmod.diff

Hi all,

FreeBSD since 10.3 has two issues with its em(4) driver at the moment, which likely also apply to FreeBSD 11, so following the steps of the intel-ixl-kmod package we propose this new port that seems not to show these regressions after thorough testing.

One of the issues is tracked here:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211219

The other issue will be documented this week, affecting at least the 82574L chipset being unstable in netmap mode.  A partial fix went into HEAD a month back, but only fixes the netmap mode partially:

https://lists.freebsd.org/pipermail/svn-src-head/2016-August/089933.html

This can also help users to get newer network drivers faster in the future.  :)


Cheers,
Franco
Comment 1 Franco Fichtner 2016-09-19 16:19:34 UTC
Created attachment 174969 [details]
poudriere testport build log
Comment 2 CS 2016-09-28 23:58:57 UTC
It's affecting more than you Franco. :) 
Thanks for submitting this, can't wait to see it included in the tree.
Comment 3 Franco Fichtner 2016-09-29 04:29:03 UTC
Created attachment 175253 [details]
revised patch

o changed license to 3-clause as per source code indication (came from the intel-ixl-kmod port)
o adjusted package description, does not include igb (came from the distfile README)
Comment 4 Serhii (Sergey) Kozlov freebsd_committer 2016-09-29 21:59:38 UTC
Created attachment 175290 [details]
slave port example

Hi all,

I'm the author of net/intel-ixl-kmod and I work for Intel.

The ixl port was made to be a master one, that means to serve as a base for other driver ports' (slaves). Here's the example of how this port would look like being a slave to net/intel-ixl-kmod. The patch includes a small change to the ixl port as well to be able to override the MAINTAINER.

This approach has some advantages:
- You don't have to repeat a lot of code
- If anything big changes to all the drivers - it will be changed in the master port and automatically propagated to others.

If you would consider this - just substitute your patch with mine.

Regards,
Sergey
Comment 5 Franco Fichtner 2016-09-30 06:59:47 UTC
Comment on attachment 175253 [details]
revised patch

Hi Sergey,

Thanks for this!  Looks better, works fine.  Obsoleting the other patch in favour of yours.  :)


Cheers,
Franco
Comment 6 commit-hook freebsd_committer 2016-10-06 20:19:01 UTC
A commit references this bug:

Author: sbruno
Date: Thu Oct  6 20:18:31 UTC 2016
New revision: 423442
URL: https://svnweb.freebsd.org/changeset/ports/423442

Log:
  Change MAINTAINER variable to support using this as a master port
  for other slave ports.

  PR:	212828
  Submitted by:	 Sergey Kozlov <kozlov.sergey.404@gmail.com>
  Reviewed by:	Franco Fichtner <franco@opnsense.org>

Changes:
  head/net/intel-ixl-kmod/Makefile
Comment 7 commit-hook freebsd_committer 2016-10-06 20:21:03 UTC
A commit references this bug:

Author: sbruno
Date: Thu Oct  6 20:20:54 UTC 2016
New revision: 423444
URL: https://svnweb.freebsd.org/changeset/ports/423444

Log:
  Add kmod port for the exact tar archive from Intel's download site for
  those folks who don't want to use the FreeBSD supported version.

  PR:	212828
  Submitted by:	 Sergey Kozlov <kozlov.sergey.404@gmail.com>
  Reviewed by:	Franco Fichtner <franco@opnsense.org>

Changes:
  head/net/Makefile
  head/net/intel-em-kmod/
  head/net/intel-em-kmod/Makefile
  head/net/intel-em-kmod/distinfo
  head/net/intel-em-kmod/pkg-descr
Comment 8 Sean Bruno freebsd_committer 2016-10-06 20:26:02 UTC
Theoretically, this is done now.
Comment 9 Franco Fichtner 2016-10-07 10:53:21 UTC
Thanks Sean!

Sergey, there is a small issue that prevents building the driver under i386 which works fine as far as I can see.  It needs to avoid pulling in the restrictions of the ixl port.  I used if ! defined(${MASTERDIR}) to work around this, can propose a patch if you want?


Cheers,
Franco
Comment 10 Franco Fichtner 2016-10-07 19:40:15 UTC
I've added a patch for review here:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213283


Cheers,
Franco